Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tls inspector filter #4188

Merged
merged 75 commits into from
Feb 3, 2021
Merged

Tls inspector filter #4188

merged 75 commits into from
Feb 3, 2021

Conversation

npolshakova
Copy link
Contributor

@npolshakova npolshakova commented Jan 26, 2021 •
edited by solo-changelog-bot bot
Loading

Description

Remove runtime flags for enabling tls inspector injection, add TLS Inspector as a filter to Gloo.

Failover seems to only add a Cluster_TransportSocketMatch if UpstreamSslConfig is set, so it should not be affected by the new TLS Inspector filter being added.

Context

solo-io#4044

Checklist:

  • I included a concise, user-facing changelog (for details, see https://github.com/solo-io/go-utils/tree/master/changelogutils) which references the issue that is resolved.
  • If I updated APIs (our protos) or helm values, I ran make install-go-tools generated-code to ensure there will be no code diff
  • I followed guidelines laid out in the Gloo Edge contribution guide
  • I opened a draft PR or added the work in progress label if my PR is not ready for review
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
    BOT NOTES:
    resolves [Migrated] Updating homebrew part of ci is broken solo-io/gloo#4044

@npolshakova npolshakova added the work in progress signals bulldozer to keep pr open (don't auto-merge) label Jan 26, 2021
@github-actions github-actions bot added the keep pr updated signals bulldozer to keep pr up to date with base branch label Jan 26, 2021
@solo-changelog-bot
Copy link

Issues linked to changelog:
solo-io#4044

@npolshakova npolshakova marked this pull request as ready for review January 27, 2021 14:40
saiskee
saiskee reviewed Jan 27, 2021
View reviewed changes
Copy link
Contributor

@saiskee saiskee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a small change and am curious about the DuringStage vs AfterStage.

@npolshakova
Copy link
Contributor Author

/kick

@npolshakova npolshakova removed the work in progress signals bulldozer to keep pr open (don't auto-merge) label Feb 2, 2021
@kdorosh kdorosh added the work in progress signals bulldozer to keep pr open (don't auto-merge) label Feb 2, 2021
@npolshakova npolshakova removed the work in progress signals bulldozer to keep pr open (don't auto-merge) label Feb 2, 2021
sam-heilbron
sam-heilbron previously approved these changes Feb 3, 2021
View reviewed changes
@npolshakova
Copy link
Contributor Author

/kick

@soloio-bulldozer soloio-bulldozer bot merged commit ddcfb31 into master Feb 3, 2021
@soloio-bulldozer soloio-bulldozer bot deleted the tls-inspector-filter branch February 3, 2021 19:15
@sam-heilbron sam-heilbron mentioned this pull request Aug 5, 2021
Closed
@github-actions github-actions bot mentioned this pull request Nov 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuval-k yuval-k yuval-k left review comments

@saiskee saiskee saiskee left review comments

@EItanya EItanya EItanya approved these changes

@sam-heilbron sam-heilbron sam-heilbron approved these changes

@kdorosh kdorosh Awaiting requested review from kdorosh

Assignees
No one assigned
Labels
keep pr updated signals bulldozer to keep pr up to date with base branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Treat TLS inspector as proper filter in filter chain, add it in control plane
6 participants
@npolshakova @yuval-k @saiskee @EItanya @sam-heilbron @kdorosh