Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat TLS inspector as proper filter in filter chain, add it in control plane #4044

Closed
kdorosh opened this issue Dec 31, 2020 · 1 comment · Fixed by #4188
Closed

Treat TLS inspector as proper filter in filter chain, add it in control plane #4044

kdorosh opened this issue Dec 31, 2020 · 1 comment · Fixed by #4188
Labels
Type: Enhancement New feature or request

Comments

@kdorosh
Copy link
Contributor

kdorosh commented Dec 31, 2020

Is your feature request related to a problem? Please describe.
Envoy used to automatically include/inject the TLS inspector, but that was removed in envoyproxy/envoy#14404. In solo-io#4041 we used runtime flags to use the older behavior, but we should remove those soon in favor of adding the filter in Gloo itself.

Describe the solution you'd like
Remove the runtime flags and add support for TLS inspector in Gloo itself; beef up testing (this was caught in upgrade to latest master envoy in our knative regression tls suite, would have been nice to debug in a simpler test)

@kdorosh kdorosh added the Type: Enhancement New feature or request label Dec 31, 2020
@EItanya
Copy link
Contributor

EItanya commented Jan 4, 2021

We already add this as part of failover in certain scenarios. So we should make sure to remove it from there when we add this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants