-
Notifications
You must be signed in to change notification settings - Fork 928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove support for Python 3.8 #4212
Remove support for Python 3.8 #4212
Conversation
Don't worry about the docs failure! It should be fixed once #4209 goes in. |
Looks great! The unused imports do need to be removed, though. |
Signed-off-by: kevin1kevin1k <kevin1kevin1k@gmail.com>
83020d2
to
724ff34
Compare
That's a sharp catch 👀! I just noticed that I didn't install and run the pre-commit so it was not caught by ruff. After running them the unused imports (along with some deprecated stuff, such as UP035 |
By the way I just manually resolved the ruff errors that look like the following.
Can these be configured to fix automatically as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @kevin1kevin1k and congrats on your first Kedro PR! ⭐ 🔶
I've left some minor comments, but they're all non-blocking.
Signed-off-by: kevin1kevin1k <kevin1kevin1k@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kevin1kevin1k! 💯
Signed-off-by: kevin1kevin1k <kevin1kevin1k@gmail.com>
…n1kevin1k/kedro into remove-support-for-python38
Signed-off-by: kevin1kevin1k <kevin1kevin1k@gmail.com>
By the way, the typing changes are mainly due to https://peps.python.org/pep-0585/ in case anyone is curious. |
Description
This fixes #4115.
Support for Python 3.8 will be removed and 3.9+ will be required.
Development notes
Most syntactical changes in Python files are automatically applied by
find . -name "*.py" -print0 | xargs -0 pyupgrade --py39-plus
.Other changes are done manually, with the references from the previous issue #2158 and PR #3060 for dropping 3.7
Developer Certificate of Origin
We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a
Signed-off-by
line in the commit message. See our wiki for guidance.If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.
Checklist
RELEASE.md
file