Drop Python 3.7 supports in Develop #3060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
11 tasks
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
|
You might want to try |
|
Didn't know this exist, will try. |
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
…kedro-org/kedro into noklam/drop-python-support-3058 Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
noklam
requested review from
yetudada,
astrojuanlu,
stichbury and
merelcht
as code owners
astrojuanlu
reviewed
Sep 22, 2023
| "importlib-metadata>=3.6,<7.0; python_version >= '3.8'", | ||
| "importlib_resources>=1.3,<7.0", # The `files()` API was introduced in `importlib_resources` 1.3 and Python 3.9. | ||
| "jmespath>=0.9.5", | ||
| "more_itertools>=8.14.0", | ||
| "omegaconf>=2.1.1", | ||
| "parse>=1.19.0", | ||
| "pip-tools>=6.5", | ||
| "pluggy>=1.0,<1.3", # TODO: Uncap when dropping Python 3.7 support, see https://github.com/kedro-org/kedro/issues/2979 |
There was a problem hiding this comment.
This causes nModuleNotFoundError: No module named \'pluggy\'
noklam
commented
Sep 27, 2023
| @@ -327,10 +327,10 @@ jobs: | |||
| - win_setup: | |||
| python_version: <<parameters.python_version>> | |||
| - when: | |||
| # Save Python package cache only for Python 3.7. The conda environment itself | |||
| # Save Python package cache only for Python 3.8. The conda environment itself | |||
There was a problem hiding this comment.
Doesn't really matter since we are going to remove CCI
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
noklam
requested review from
astrojuanlu and
SajidAlamQB
and removed request for
yetudada and
merelcht
merelcht
approved these changes
Sep 27, 2023
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
…kedro-org/kedro into noklam/drop-python-support-3058 Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
|
Farewell, Python 3.7 👋🏽 |
This was referenced Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Close #2158
Development notes
importlib_metadata, replace with standard libraryimportlib.metadataChecklist
RELEASE.mdfile