-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix enforce-pact-version decimal parser #1334
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xd34df00d
reviewed
Feb 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this change be under a flag?
It probably shouldn't, since there is no difference in behavior for the already running nodes, and the version where it'd make a difference isn't deployed yet, so it's OK.
0xd34df00d
approved these changes
Feb 10, 2024
This PR closed #1334 |
rsoeldner
approved these changes
Feb 10, 2024
rsoeldner
reviewed
Feb 10, 2024
6 tasks
Co-authored-by: rsoeldner <r.soeldner@gmail.com>
Co-authored-by: rsoeldner <r.soeldner@gmail.com>
Fixes #1327 |
jmcardon
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enforce-pact-version
was actually using lexicographic comparison due to the fact that the digit-parser is a stringy parser:The problem:
Which leads to the following case for the first time in Pact's history, now that it has a double-digit version part:
🎉
This PR uses integer parsing on the version segments:
PR checklist:
* [ ] Documentation has been updated if new natives or FV properties have been added. To generate new documentation, issuecabal run tests
. If they pass locally, docs are generated.* [ ] Any changes that could be relevant to users have been recorded in the changelog* [ ] In case of changes to the Pact trace output (pact -t
), make sure pact-lsp is in sync.Additionally, please justify why you should or should not do the following: