New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

`enforce-pact-version` test case #106

Merged

jmcardon merged 1 commit into master from rsoeldner/pact-time-test

Feb 10, 2024

Member

rsoeldner commented Feb 10, 2024

This PR adds a missing test case, which was added in prod: kadena-io/pact#1334

The check against pact-version.

PR checklist:

Test coverage for the proposed changes
PR description contains example output from repl interaction or a snippet from unit test output
Any changes that could be relevant to users have been recorded in the changelog

Additionally, please justify why you should or should not do the following:

Confirm replay/back compat
Benchmark regressions
(For Kadena engineers) Run integration-tests against a Chainweb built with this version of Pact


          add additional test case

242b5af

rsoeldner requested review from jwiegley, emilypi and jmcardon as code owners

February 10, 2024 08:50

emilypi approved these changes

View reviewed changes

0xd34df00d approved these changes

View reviewed changes

jmcardon merged commit b3f2c86 into master

3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet