Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace Fsa with Array2 in Aux_labels #59

Merged
merged 2 commits into from
Jun 16, 2020
Merged

Conversation

qindazhu
Copy link
Collaborator

Note that as we have defined (const) begin and (const) end for Array2, we can now use range-based for-loop, as I do in IsTopSorted

 for (const auto &arc : fsa) {
   if (arc.dest_state < arc.src_state) return false;
 }

@danpovey
Copy link
Collaborator

.. otherwise OK.

@qindazhu
Copy link
Collaborator Author

@danpovey I set indexes = &size1 in Array2 and reset it to nullptr in the constructor of Fsa (it's just temporary code for distinguishing whether the Fsa object is constructed using Array2 or origianl arc_indexes and arcs, will remove it finally).

@danpovey
Copy link
Collaborator

danpovey commented Jun 15, 2020 via email

@qindazhu
Copy link
Collaborator Author

Merging.

@qindazhu qindazhu merged commit 4b1e5e8 into k2-fsa:master Jun 16, 2020
@qindazhu qindazhu deleted the haowen-aux branch June 16, 2020 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants