remove Range in Fsa #14
Conversation
|
OK, updated with |
qindazhu
force-pushed
the
haowen-fsa-property
branch
from
c079cc4 to
524505d
Compare
|
+2 merging. |
| @@ -33,18 +33,16 @@ bool IsValid(const Fsa &fsa) { | |||
| } else { | |||
| // every state contains at least one arc. | |||
There was a problem hiding this comment.
This is an issue in previous code, but RE "only epsilon arcs enter the final state", this is not right, it should be kFinalSymbol (-1). You may have to change other code. This change is necessary, things will break later if you leave it as epsilon.
There was a problem hiding this comment.
RE "every state contains at least one arc": firstly, you should word it as "every state has at least one arc leaving it". But actually this condition is not required for an FSA to be valid (it would just not be connected).
There was a problem hiding this comment.
.. also you should probably make it so that this code can't segfault even if the input is invalid.
| return false; | ||
| state = arc.src_state; | ||
| num_arcs = 1; | ||
| } | ||
| } | ||
| // check the last state | ||
| if (final_state != state + 1) return false; | ||
| if ((fsa.leaving_arcs[final_state].begin - fsa.leaving_arcs[state].begin) != | ||
| num_arcs) | ||
| if ((fsa.arc_indexes[final_state] - fsa.arc_indexes[state]) != num_arcs) |
There was a problem hiding this comment.
... this code is hard for me to understand and to verify that it's correct. I think it would be much clearer if the iteration were done over fsa.arc_indexes.
No description provided.