-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
revset: add function mine() #2091
Conversation
I would probably go with using only the email. That avoids problems with non-unique names. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
We generally include documentation with the code changes, so please squash the three commits into one. One exception is if we don't want users to know about the change until it's reached a released version. In such cases, it would be a whole separate PR, however. See some more discussion in https://github.com/martinvonz/jj/blob/main/docs/contributing.md#code-reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again. Feel free to merge when the checks pass.
I squashed the three commits into one. |
mine()
is an alias forauthor([user.name])
per the specification given in #1976, although I wonder if it should instead act likeauthor([user.name]) | author([user.email])
.Checklist
If applicable:
CHANGELOG.md