Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revset: add function mine() #2091

Merged
merged 1 commit into from
Aug 16, 2023
Merged

revset: add function mine() #2091

merged 1 commit into from
Aug 16, 2023

Conversation

emilykfox
Copy link
Contributor

mine() is an alias for author([user.name]) per the specification given in #1976, although I wonder if it should instead act like author([user.name]) | author([user.email]).

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (src/config-schema.json)
  • I have added tests to cover my changes

@martinvonz
Copy link
Member

I wonder if it should instead act like author([user.name]) | author([user.email]).

I would probably go with using only the email. That avoids problems with non-unique names.

Copy link
Member

@martinvonz martinvonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

We generally include documentation with the code changes, so please squash the three commits into one. One exception is if we don't want users to know about the change until it's reached a released version. In such cases, it would be a whole separate PR, however. See some more discussion in https://github.com/martinvonz/jj/blob/main/docs/contributing.md#code-reviews.

Copy link
Member

@martinvonz martinvonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again. Feel free to merge when the checks pass.

@emilykfox
Copy link
Contributor Author

Thanks!

We generally include documentation with the code changes, so please squash the three commits into one. One exception is if we don't want users to know about the change until it's reached a released version. In such cases, it would be a whole separate PR, however. See some more discussion in https://github.com/martinvonz/jj/blob/main/docs/contributing.md#code-reviews.

I squashed the three commits into one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants