FR: Make the mine() revset builtin

[PhilipMetzger]

At the moment all users need to setup the revset alias by themselves, this is trivial but it should be builtin.

The alias looks like this:

# In config.toml
[revset-aliases]
'mine()' = 'author(your-name)' 

The implementation should look something like this:

impl RevSetExpression {
   // ...
    fn mine(self: &Rc<RevSetExpression>) -> Rc<RevSetExpression> {
    // Read the user.name field
    let author_name = ...;
    // ...
    Rc::new(RevsetExpression::filter(RevsetFilterPredicate::Author(
            author_name,
         )))
  } 

}

Then you need to add it to the builtins function map, without expecting arguments
https://github.com/martinvonz/jj/blob/85b66e43f06bd58045d991d047bd7c142fb09622/lib/src/revset.rs#L932-L946

Then you only need to add tests to finish your first contribution, don't forget to sign the CLA.

[Dr-Emann]

I'm not sure how to get access to the overall jj config to get the author that's configured, as far as I can tell, there's not a way to currently get there from any of the arguments to RevsetFunction, but I could be missing something.

[PhilipMetzger]

You'll need a to add a dependency on the cli crate, to get access to LayeredConfigs . See martin's answer

[martinvonz]

You'll need a to add a dependency on the cli crate, to get access to LayeredConfigs .

We don't want dependencies from the lib crate to the CLI crate. See https://github.com/martinvonz/jj/blob/main/docs/technical/architecture.md#separation-of-library-from-ui.

I think we can instead pass in the current username into the revset::parse() function, much like the workspace_ctx argument we already pass to that function.

[emilykfox]

mine() is now available. However, it aliases the user's email address instead of their name.

[PhilipMetzger]

LGTM, thanks for implementing it.