Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist ReplayFlowFactoryAction#sandbox #968

Merged
merged 3 commits into from
Jan 6, 2025
Merged

Persist ReplayFlowFactoryAction#sandbox #968

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
087e226
Persist ReplayFlowFactoryAction#sandbox
Vlatombe Jan 6, 2025
43a23b5
Add a test failing without the patch
Vlatombe Jan 6, 2025
442b2cb
Clean up
Vlatombe Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugin/src/main/java/org/jenkinsci/plugins/workflow/cps/replay/ReplayFlowFactoryAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ class ReplayFlowFactoryAction extends InvisibleAction implements CpsFlowFactoryA

private String replacementMainScript;
private final Map<String,String> replacementLoadedScripts;
private transient final boolean sandbox;
private final boolean sandbox;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could avoid persisting it in build.xml as well, though unlike replacementMainScript the size impact is negligible.


ReplayFlowFactoryAction(@NonNull String replacementMainScript, @NonNull Map<String,String> replacementLoadedScripts, boolean sandbox) {
this.replacementMainScript = replacementMainScript;
Expand Down
Loading