Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist ReplayFlowFactoryAction#sandbox #968

Merged
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Persist ReplayFlowFactoryAction#sandbox
In CBCI HA scenarios, the Queue.Item (and its actions) can be rescheduled in another Jenkins replica. In such case it is required to persist the `sandbox` field, otherwise the reschedule will run without sandbox.
  • Loading branch information
Vlatombe committed Jan 6, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit 087e226b00c327b9fcaea5d8686dfcda8c9974f7
Original file line number Diff line number Diff line change
@@ -52,7 +52,7 @@ class ReplayFlowFactoryAction extends InvisibleAction implements CpsFlowFactoryA

private String replacementMainScript;
private final Map<String,String> replacementLoadedScripts;
private transient final boolean sandbox;
private final boolean sandbox;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could avoid persisting it in build.xml as well, though unlike replacementMainScript the size impact is negligible.


ReplayFlowFactoryAction(@NonNull String replacementMainScript, @NonNull Map<String,String> replacementLoadedScripts, boolean sandbox) {
this.replacementMainScript = replacementMainScript;
Loading