Update baseline to 2.414.x #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jglick
commented
Feb 29, 2024
| [ platform: "linux", jdk: "11"], | ||
| [ platform: "linux", jdk: "17"], | ||
| [ platform: "windows", jdk: "11"] | ||
| /* |
| <artifactId>bom-2.361.x</artifactId> | ||
| <version>2102.v854b_fec19c92</version> | ||
| <artifactId>bom-2.414.x</artifactId> | ||
| <version>2839.v003b_4d9d24fd</version> |
There was a problem hiding this comment.
Also currently latest BOM for this line.
|
Not sure what is causing the |
jglick
commented
Mar 1, 2024
| @@ -91,7 +96,7 @@ public void addContentsRunningBuild() throws Exception { | |||
| WorkflowRun workflowRun = Optional.ofNullable(p.scheduleBuild2(0)) | |||
| .orElseThrow(AssertionFailedError::new) | |||
| .waitForStart(); | |||
| j.waitForMessage("Running on", workflowRun); | |||
| SemaphoreStep.waitForStart("wait/1", workflowRun); | |||
There was a problem hiding this comment.
@cloudbees internal reference: BEE-41313
Comment on lines
+197
to
+198
| SemaphoreStep.success("wait/1", null); | ||
| j.waitForCompletion(workflowRun); |
rsandell
reviewed
Mar 4, 2024
| useContainerAgent: true, // Set to `false` if you need to use Docker for containerized tests | ||
| configurations: [ | ||
| [platform: 'linux', jdk: 21], | ||
| [platform: 'windows', jdk: 17], |
There was a problem hiding this comment.
I am still baffled why this is the recommended setting. From a cost perspective sure. But I believe there should at least be one combination where just one variable is different.
There was a problem hiding this comment.
This is not the place to discuss it; just copying the Jenkinsfile from archetypes.
rsandell
approved these changes
Mar 4, 2024
jglick
added
developer
and removed
dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The oldest suggested baseline according to https://www.jenkins.io/doc/developer/plugin-development/choosing-jenkins-baseline/#currently-recommended-versions