Overhaul of SlaveLaunchLogs
#517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jglick
commented
Mar 1, 2024
Comment on lines
+154
to
+155
| out.write(DateTimeFormatter.ISO_INSTANT | ||
| .format(Instant.now().truncatedTo(ChronoUnit.MILLIS)) |
There was a problem hiding this comment.
See jenkinsci/lib-support-log-formatter#64 for other logs.
jglick
commented
Mar 4, 2024
Vlatombe
approved these changes
Mar 8, 2024
Vlatombe
approved these changes
Mar 18, 2024
Dohbedoh
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The collection of launch logs from agents is rather antiquated given the prevalence of
Clouds and is missing a lot of critical diagnostics. (CloudBees-internal reference: BEE-44099) Some observations:SlaveLaunchLogsclaims to include logs from ephemeral agents but does not. Perhaps it once did, but jenkinsci/jenkins#1681 broke this:SlaveComputer.killdeletesComputer.logDirwhen the computer is removed. (Despite the appearance in the executor widget, this does not happen merely because an agent is disconnected, soSlaveLaunchLogswill still include an entry for that agent while offline.) Not so easy to work around because this happens fromJenkins.updateComputerList, beforeNodeListener.fireOnDeletedis fired, and potentially before or concurrently withComputerListener.onOffline.SlaveLaunchLogsdoes not honorSafeTimerTask.getLogsRoot(). (This is set by CloudBees CI HA controllers.)These issues can be solved in a straightforward way by just collecting all agent launch logs in one (rotated) log file, with every line prefixed by a timestamp and agent name. Downstream of jenkinsci/jenkins#9009 (without which the new system for log collection
cannot workcannot work so easily for inbound agents).Needs to be squash-merged since things went back and forth quite a bit here.