Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disables extension auto-reload when saving files #1788

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

kellyguo11
Copy link
Contributor

Description

Since extensions are now added to the app files, they get automatically reloaded when changes happen in the extension scripts. This feature is most likely not useful for Isaac Lab development workflows. This change disables the hot reload feature as it causes confusion and unnecessary reloading of the modules.

Fixes #1779

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

Copy link
Contributor

@Mayankm96 Mayankm96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this extension specific or we should disable it completely for all the extensions when launching the simulator from Python?

@kellyguo11
Copy link
Contributor Author

I believe it's a setting we have to add for each extension, seems like it's only available through the extension.toml file.

@Mayankm96 Mayankm96 added the enhancement New feature or request label Feb 12, 2025
@Mayankm96 Mayankm96 merged commit 62d1de9 into isaac-sim:main Feb 13, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] IsaacLab modules' auto-reloading mechanism.
2 participants