Skip to content

Commit

Permalink
Disables extension auto-reload when saving files (#1788)
Browse files Browse the repository at this point in the history
# Description

Since extensions are now added to the app files, they get automatically
reloaded when changes happen in the extension scripts. This feature is
most likely not useful for Isaac Lab development workflows. This change
disables the hot reload feature as it causes confusion and unnecessary
reloading of the modules.

Fixes #1779 

<!-- As a practice, it is recommended to open an issue to have
discussions on the proposed pull request.
This makes it easier for the community to keep track of what is being
developed or added, and if a given feature
is demanded by more than one party. -->

## Type of change

<!-- As you go through the list, delete the ones that are not
applicable. -->

- Bug fix (non-breaking change which fixes an issue)

## Checklist

- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./isaaclab.sh --format`
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
- [x] I have added my name to the `CONTRIBUTORS.md` or my name already
exists there

<!--
As you go through the checklist above, you can mark something as done by
putting an x character in it

For example,
- [x] I have done this task
- [ ] I have not done this task
-->

Co-authored-by: Mayank Mittal <12863862+Mayankm96@users.noreply.github.com>
  • Loading branch information
kellyguo11 and Mayankm96 authored Feb 13, 2025
1 parent c4bec8f commit 62d1de9
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 0 deletions.
3 changes: 3 additions & 0 deletions source/isaaclab/config/extension.toml
Original file line number Diff line number Diff line change
Expand Up @@ -32,5 +32,8 @@ modules = [

use_online_index=true

[core]
reloadable = false

[[python.module]]
name = "isaaclab"
3 changes: 3 additions & 0 deletions source/isaaclab_assets/config/extension.toml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ keywords = ["kit", "robotics", "assets", "isaaclab"]
[dependencies]
"isaaclab" = {}

[core]
reloadable = false

# Main python module this extension provides.
[[python.module]]
name = "isaaclab_assets"
3 changes: 3 additions & 0 deletions source/isaaclab_mimic/config/extension.toml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@ keywords = ["extension", "template", "isaaclab"]
"isaaclab_tasks" = {}
# NOTE: Add additional dependencies here

[core]
reloadable = false

[[python.module]]
name = "isaaclab_mimic"

Expand Down
3 changes: 3 additions & 0 deletions source/isaaclab_rl/config/extension.toml
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,8 @@ keywords = ["robotics", "rl", "wrappers", "learning"]
"isaaclab_assets" = {}
"isaaclab_tasks" = {}

[core]
reloadable = false

[[python.module]]
name = "isaaclab_rl"
3 changes: 3 additions & 0 deletions source/isaaclab_tasks/config/extension.toml
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,8 @@ keywords = ["robotics", "rl", "il", "learning"]
"isaaclab" = {}
"isaaclab_assets" = {}

[core]
reloadable = false

[[python.module]]
name = "isaaclab_tasks"

0 comments on commit 62d1de9

Please sign in to comment.