Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: links without paths can be navigated #462

Merged
merged 3 commits into from
Nov 21, 2024

Conversation

SgtPooki
Copy link
Member

  • chore: remove unnecessary any cast
  • chore: fix return type on isTruthy
  • fix: links without paths can be navigated

Fixes #461

See description of bug at #461 (comment)

@SgtPooki SgtPooki requested a review from a team as a code owner November 21, 2024 16:04
@SgtPooki SgtPooki linked an issue Nov 21, 2024 that may be closed by this pull request
@SgtPooki SgtPooki requested a review from lidel November 21, 2024 16:04
@SgtPooki SgtPooki self-assigned this Nov 21, 2024
@SgtPooki SgtPooki merged commit 1effbe7 into master Nov 21, 2024
16 checks passed
@SgtPooki SgtPooki deleted the 461-unable-to-traverse-inside-of-a-chunked-file branch November 21, 2024 16:28
github-actions bot pushed a commit that referenced this pull request Nov 21, 2024
## [8.1.1](v8.1.0...v8.1.1) (2024-11-21)

### Bug Fixes

* links without paths can be navigated ([#462](#462)) ([1effbe7](1effbe7)), closes [#461](#461)
Copy link
Contributor

🎉 This PR is included in version 8.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

lidel added a commit to ipfs/ipfs-webui that referenced this pull request Nov 29, 2024
This includes latest ipld-explorer-components with fix from
ipfs/ipld-explorer-components#462

also bumped kubo and caniuse and non-breaking audit suggestions
lidel added a commit to ipfs/ipfs-webui that referenced this pull request Nov 29, 2024
This includes latest ipld-explorer-components with fix from
ipfs/ipld-explorer-components#462

also bumped kubo and caniuse and non-breaking audit suggestions
lidel added a commit to ipfs/ipfs-webui that referenced this pull request Nov 29, 2024
…2305)

* fix(explore): chunked files

This includes latest ipld-explorer-components with fix from
ipfs/ipld-explorer-components#462

also bumped kubo and caniuse and non-breaking audit suggestions

* fix(files): Inspect via context menu

Closes #2306
MattWong-ca pushed a commit to MattWong-ca/ipfs-webui that referenced this pull request Dec 14, 2024
…pfs#2305)

* fix(explore): chunked files

This includes latest ipld-explorer-components with fix from
ipfs/ipld-explorer-components#462

also bumped kubo and caniuse and non-breaking audit suggestions

* fix(files): Inspect via context menu

Closes ipfs#2306
SgtPooki added a commit to ipfs/ipfs-webui that referenced this pull request Feb 27, 2025
* Start bulk CID import

* Get functional MVP working with csv file

* Get it working with txt file

* WIP: bulk import modal UX

* WIP, need to debug modal UX

* Modal UX working, need to clean up code

* Remove comments

* Clean code

* Add validation to file select

* Use localization

* Add correct type, remove progress tracking

* Refactor code

* Add storybook file

* Remove comments

* Update Add menu test

* Remove prop-types

* Use functional component

* Use useTranslation

* Update to TS file

* Update import path

* fix(explore): browsing chunked files and inspecting via context menu (#2305)

* fix(explore): chunked files

This includes latest ipld-explorer-components with fix from
ipfs/ipld-explorer-components#462

also bumped kubo and caniuse and non-breaking audit suggestions

* fix(files): Inspect via context menu

Closes #2306

* chore(ci): set cluster pin timeout to 30m

https://github.com/ipfs/ipfs-webui/actions/workflows/ci.yml?page=4&query=is%3Asuccess 
are usually under 10-20 minutes
if something takes longer it will likely take ages and then fail, 
so better to fail faster, allowing user to retry release

* chore(ci): use repo in offline mode

no need to start node and open outgoing connections
github CI may be punishing us by throttling egress

* Get functional MVP working with csv file

* Get it working with txt file

* WIP: bulk import modal UX

* WIP, need to debug modal UX

* Modal UX working, need to clean up code

* Remove comments

* Clean code

* Add validation to file select

* Use localization

* Add correct type, remove progress tracking

* Refactor code

* Add storybook file

* Remove comments

* Update Add menu test

* chore(release): 4.4.1 [skip ci]

## [4.4.1](v4.4.0...v4.4.1) (2024-11-30)

 CID `bafybeiatztgdllxnp5p6zu7bdwhjmozsmd7jprff4bdjqjljxtylitvss4`

 ---

### Bug Fixes

* add lithuanian to languages.json ([#2293](#2293)) ([40c512b](40c512b))
* analyze script doesn't persist stats.json ([#2290](#2290)) ([dbbdd70](dbbdd70))
* **explore:** browsing chunked files and inspecting via context menu ([#2305](#2305)) ([0412970](0412970)), closes [#2306](#2306)

### Trivial Changes

* **ci:** add CAR file directly to cluster ([#2304](#2304)) ([e2ae110](e2ae110))
* **ci:** no replication factor when pinning - use cluster's default ([#2302](#2302)) ([81b8f29](81b8f29))
* **ci:** set cluster pin timeout to 30m ([4b8fc00](4b8fc00))
* **ci:** udpate artifact actions to v4 ([#2292](#2292)) ([305908f](305908f))
* **ci:** use repo in offline mode ([eaf63ed](eaf63ed))
* pull new translations ([#2291](#2291)) ([bfe7e40](bfe7e40))
* pull transifex translations ([#2296](#2296)) ([502abd4](502abd4))
* pull transifex translations ([#2303](#2303)) ([89c094b](89c094b))
* size-related labels in Files screen ([#2295](#2295)) ([49019d4](49019d4))

* chore: pull new translations (#2308)

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: lidel <lidel@users.noreply.github.com>

* Remove prop-types

* Use functional component

* Use useTranslation

* Update to TS file

* Update import path

---------

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Marcin Rataj <lidel@lidel.org>
Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: lidel <lidel@users.noreply.github.com>
Co-authored-by: Russell Dempsey <1173416+SgtPooki@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to traverse inside of a chunked file
1 participant