Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: size-related labels in Files screen #2295

Merged
merged 5 commits into from
Nov 14, 2024
Merged

docs: size-related labels in Files screen #2295

merged 5 commits into from
Nov 14, 2024

Conversation

lidel
Copy link
Member

@lidel lidel commented Nov 14, 2024

Closes #1248 without changing UI.

We just clarify that it is normal if the first number is bigger than the second one.

When at the root of MFS (all files):

2024-11-14_22-24

We now have more friendly label when in a subdirectory:

2024-11-14_22-24_1

While at it, also added this disclaimer to "Import IPFS Path" :

2024-11-14_22-24_2

@lidel lidel requested a review from SgtPooki November 14, 2024 18:54
@lidel lidel marked this pull request as ready for review November 14, 2024 18:54
@lidel lidel requested a review from a team as a code owner November 14, 2024 18:54
reducing confusion + forcing fresh translation without historical ones
similar, make it more clear the value applies to currently displayed
directory
@lidel lidel changed the title docs: clarify mfs total size caveat docs: size-related labels in Files screen Nov 14, 2024
Copy link
Member

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, awesome

@lidel lidel merged commit 49019d4 into main Nov 14, 2024
20 checks passed
@lidel lidel deleted the clarify-mfs-size branch November 14, 2024 22:03
ipfs-gui-bot pushed a commit that referenced this pull request Nov 30, 2024
## [4.4.1](v4.4.0...v4.4.1) (2024-11-30)

 CID `bafybeiatztgdllxnp5p6zu7bdwhjmozsmd7jprff4bdjqjljxtylitvss4`

 ---

### Bug Fixes

* add lithuanian to languages.json ([#2293](#2293)) ([40c512b](40c512b))
* analyze script doesn't persist stats.json ([#2290](#2290)) ([dbbdd70](dbbdd70))
* **explore:** browsing chunked files and inspecting via context menu ([#2305](#2305)) ([0412970](0412970)), closes [#2306](#2306)

### Trivial Changes

* **ci:** add CAR file directly to cluster ([#2304](#2304)) ([e2ae110](e2ae110))
* **ci:** no replication factor when pinning - use cluster's default ([#2302](#2302)) ([81b8f29](81b8f29))
* **ci:** set cluster pin timeout to 30m ([4b8fc00](4b8fc00))
* **ci:** udpate artifact actions to v4 ([#2292](#2292)) ([305908f](305908f))
* **ci:** use repo in offline mode ([eaf63ed](eaf63ed))
* pull new translations ([#2291](#2291)) ([bfe7e40](bfe7e40))
* pull transifex translations ([#2296](#2296)) ([502abd4](502abd4))
* pull transifex translations ([#2303](#2303)) ([89c094b](89c094b))
* size-related labels in Files screen ([#2295](#2295)) ([49019d4](49019d4))
@ipfs-gui-bot
Copy link
Collaborator

🎉 This PR is included in version 4.4.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

MattWong-ca pushed a commit to MattWong-ca/ipfs-webui that referenced this pull request Dec 14, 2024
## [4.4.1](ipfs/ipfs-webui@v4.4.0...v4.4.1) (2024-11-30)

 CID `bafybeiatztgdllxnp5p6zu7bdwhjmozsmd7jprff4bdjqjljxtylitvss4`

 ---

### Bug Fixes

* add lithuanian to languages.json ([ipfs#2293](ipfs#2293)) ([40c512b](ipfs@40c512b))
* analyze script doesn't persist stats.json ([ipfs#2290](ipfs#2290)) ([dbbdd70](ipfs@dbbdd70))
* **explore:** browsing chunked files and inspecting via context menu ([ipfs#2305](ipfs#2305)) ([0412970](ipfs@0412970)), closes [ipfs#2306](ipfs#2306)

### Trivial Changes

* **ci:** add CAR file directly to cluster ([ipfs#2304](ipfs#2304)) ([e2ae110](ipfs@e2ae110))
* **ci:** no replication factor when pinning - use cluster's default ([ipfs#2302](ipfs#2302)) ([81b8f29](ipfs@81b8f29))
* **ci:** set cluster pin timeout to 30m ([4b8fc00](ipfs@4b8fc00))
* **ci:** udpate artifact actions to v4 ([ipfs#2292](ipfs#2292)) ([305908f](ipfs@305908f))
* **ci:** use repo in offline mode ([eaf63ed](ipfs@eaf63ed))
* pull new translations ([ipfs#2291](ipfs#2291)) ([bfe7e40](ipfs@bfe7e40))
* pull transifex translations ([ipfs#2296](ipfs#2296)) ([502abd4](ipfs@502abd4))
* pull transifex translations ([ipfs#2303](ipfs#2303)) ([89c094b](ipfs@89c094b))
* size-related labels in Files screen ([ipfs#2295](ipfs#2295)) ([49019d4](ipfs@49019d4))
SgtPooki added a commit that referenced this pull request Feb 27, 2025
* Start bulk CID import

* Get functional MVP working with csv file

* Get it working with txt file

* WIP: bulk import modal UX

* WIP, need to debug modal UX

* Modal UX working, need to clean up code

* Remove comments

* Clean code

* Add validation to file select

* Use localization

* Add correct type, remove progress tracking

* Refactor code

* Add storybook file

* Remove comments

* Update Add menu test

* Remove prop-types

* Use functional component

* Use useTranslation

* Update to TS file

* Update import path

* fix(explore): browsing chunked files and inspecting via context menu (#2305)

* fix(explore): chunked files

This includes latest ipld-explorer-components with fix from
ipfs/ipld-explorer-components#462

also bumped kubo and caniuse and non-breaking audit suggestions

* fix(files): Inspect via context menu

Closes #2306

* chore(ci): set cluster pin timeout to 30m

https://github.com/ipfs/ipfs-webui/actions/workflows/ci.yml?page=4&query=is%3Asuccess 
are usually under 10-20 minutes
if something takes longer it will likely take ages and then fail, 
so better to fail faster, allowing user to retry release

* chore(ci): use repo in offline mode

no need to start node and open outgoing connections
github CI may be punishing us by throttling egress

* Get functional MVP working with csv file

* Get it working with txt file

* WIP: bulk import modal UX

* WIP, need to debug modal UX

* Modal UX working, need to clean up code

* Remove comments

* Clean code

* Add validation to file select

* Use localization

* Add correct type, remove progress tracking

* Refactor code

* Add storybook file

* Remove comments

* Update Add menu test

* chore(release): 4.4.1 [skip ci]

## [4.4.1](v4.4.0...v4.4.1) (2024-11-30)

 CID `bafybeiatztgdllxnp5p6zu7bdwhjmozsmd7jprff4bdjqjljxtylitvss4`

 ---

### Bug Fixes

* add lithuanian to languages.json ([#2293](#2293)) ([40c512b](40c512b))
* analyze script doesn't persist stats.json ([#2290](#2290)) ([dbbdd70](dbbdd70))
* **explore:** browsing chunked files and inspecting via context menu ([#2305](#2305)) ([0412970](0412970)), closes [#2306](#2306)

### Trivial Changes

* **ci:** add CAR file directly to cluster ([#2304](#2304)) ([e2ae110](e2ae110))
* **ci:** no replication factor when pinning - use cluster's default ([#2302](#2302)) ([81b8f29](81b8f29))
* **ci:** set cluster pin timeout to 30m ([4b8fc00](4b8fc00))
* **ci:** udpate artifact actions to v4 ([#2292](#2292)) ([305908f](305908f))
* **ci:** use repo in offline mode ([eaf63ed](eaf63ed))
* pull new translations ([#2291](#2291)) ([bfe7e40](bfe7e40))
* pull transifex translations ([#2296](#2296)) ([502abd4](502abd4))
* pull transifex translations ([#2303](#2303)) ([89c094b](89c094b))
* size-related labels in Files screen ([#2295](#2295)) ([49019d4](49019d4))

* chore: pull new translations (#2308)

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: lidel <lidel@users.noreply.github.com>

* Remove prop-types

* Use functional component

* Use useTranslation

* Update to TS file

* Update import path

---------

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Marcin Rataj <lidel@lidel.org>
Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: lidel <lidel@users.noreply.github.com>
Co-authored-by: Russell Dempsey <1173416+SgtPooki@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: improve repo size labels and explanation
3 participants