Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separate openrave independent part query_grasp #126

Merged
merged 10 commits into from
Sep 8, 2017

Conversation

fmessmer
Copy link
Member

part of #125

@ipa-rmb @ipa-rmb-pz FYI

@fmessmer
Copy link
Member Author

fmessmer commented Aug 12, 2017

@ipa-rmb @ipa-rmb-pz
I added a show_grasps_rviz action_server that uses rviz for visualization of the grasps - in addition to show_grasps_or that used OpenRAVE...beside querying the grasps you can now also visualize the grasps without having OpenRAVE installed...this should significantly help debugging the grasptables which are passed to cob_pick_place_action and MoveIt!

It might not be perfect yet, but it already shows a few issues (see the TODOs in the server) that might be the problem why MoveIt! is unable to find a plan for picking up the object:

  • it complains about invalid quaternion for all grasp_poses of the sdhx...
  • there again is the issue with "side-encoded" joint names, i.e. gripper_1_joint vs. gripper_left_1_joint
  • currently you cannot view the grasps for the sdh due to the mimic joint

Still, if you continue using this tools...it should be of significant help as you do not need to install OpenRAVE at all!

@fmessmer
Copy link
Member Author

fmessmer commented Aug 12, 2017

I fixed the handling of mimic joints and the quaternion normalization
couldn't leave it like this....I was too curious myself...:stuck_out_tongue_winking_eye:

now you clearly see that the problem with grasping with the sdhx is the grasp_poses...this can easily be fixed by modifying the csv-files!

grasp_pose_sdhx_pringles

sdh grasptables look fine:
grasp_pose_sdh_hotpot

By the way, you run the visualization like so:

  • roslaunch cob_grasp_generation show_grasp_rviz.launch gripper:=sdh (or sdhx)
  • rosrun cob_grasp_generation show_grasps_rviz_client.py (then enter object_name and gripper_type)

@ipa-rmb
Copy link
Contributor

ipa-rmb commented Aug 14, 2017

Awesome, thanks for looking into this. I am looking forward to see this in operation by my student.

ipa-rmb
ipa-rmb previously approved these changes Aug 14, 2017
@@ -1,123 +0,0 @@
#!/usr/bin/env python
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove this file? Was it obsolete?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nothing is lost...i created separate nodes for each action...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha, excellent. Thanks.

@fmessmer
Copy link
Member Author

fmessmer commented Sep 4, 2017

@ipa-rmb @ipa-rmb-pz did you do any further tests/enhancements with/ontopof this?
what's the current status?

@ipa-bfb @ipa-aep FYI

@ipa-rmb-pz
Copy link
Contributor

ipa-rmb-pz commented Sep 7, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants