feat(iota-procotol, iota-adapter-tx-tests): Update how we handle type errors in some commands

crates/iota-adapter-transactional-tests/tests/programmable/make_vec_non_existent_type.exp

@@ -0,0 +1,16 @@
+processed 3 tasks
+
+init:
+A: object(0,0)
+
+task 1, lines 8-9:
+//# programmable --sender A 
+//> 0: MakeMoveVec<std::string::utf8>([]);
+Error: Transaction Effects Status: Error for type argument at index 0: A type was not found in the module specified.
+Execution Error: ExecutionError: ExecutionError { inner: ExecutionErrorInner { kind: TypeArgumentError { argument_idx: 0, kind: TypeNotFound }, source: None, command: Some(0) } }
+
+task 2, lines 11-12:
+//# programmable --sender A --inputs 1
+//> 0: MakeMoveVec<std::string::utf8>([Input(0)]);
+Error: Transaction Effects Status: Error for type argument at index 0: A type was not found in the module specified.
+Execution Error: ExecutionError: ExecutionError { inner: ExecutionErrorInner { kind: TypeArgumentError { argument_idx: 0, kind: TypeNotFound }, source: None, command: Some(0) } }

crates/iota-adapter-transactional-tests/tests/programmable/make_vec_non_existent_type.move

@@ -0,0 +1,12 @@
+// Copyright (c) Mysten Labs, Inc.
+// Modifications Copyright (c) 2024 IOTA Stiftung
+// SPDX-License-Identifier: Apache-2.0
+
+
+//# init --addresses test=0x0 --accounts A
+
+//# programmable --sender A 
+//> 0: MakeMoveVec<std::string::utf8>([]);
+
+//# programmable --sender A --inputs 1
+//> 0: MakeMoveVec<std::string::utf8>([Input(0)]);

crates/iota-adapter-transactional-tests/tests/programmable/make_vec_non_existent_type_v4.exp

@@ -0,0 +1,16 @@
+processed 3 tasks
+
+init:
+A: object(0,0)
+
+task 1, lines 8-9:
+//# programmable --sender A 
+//> 0: MakeMoveVec<std::string::utf8>([]);
+Error: Transaction Effects Status: MOVE VM INVARIANT VIOLATION.
+Execution Error: ExecutionError: ExecutionError { inner: ExecutionErrorInner { kind: VMInvariantViolation, source: Some(VMError { major_status: TYPE_RESOLUTION_FAILURE, sub_status: None, message: Some("Cannot find std::string::utf8 in cache"), exec_state: None, location: Undefined, indices: [], offsets: [] }), command: Some(0) } }
+
+task 2, lines 11-12:
+//# programmable --sender A --inputs 1
+//> 0: MakeMoveVec<std::string::utf8>([Input(0)]);
+Error: Transaction Effects Status: MOVE VM INVARIANT VIOLATION.
+Execution Error: ExecutionError: ExecutionError { inner: ExecutionErrorInner { kind: VMInvariantViolation, source: Some(VMError { major_status: TYPE_RESOLUTION_FAILURE, sub_status: None, message: Some("Cannot find std::string::utf8 in cache"), exec_state: None, location: Undefined, indices: [], offsets: [] }), command: Some(0) } }

crates/iota-adapter-transactional-tests/tests/programmable/make_vec_non_existent_type_v4.move

@@ -0,0 +1,12 @@
+// Copyright (c) Mysten Labs, Inc.
+// Modifications Copyright (c) 2024 IOTA Stiftung
+// SPDX-License-Identifier: Apache-2.0
+
+
+//# init --addresses test=0x0 --accounts A --protocol-version 4
+
+//# programmable --sender A 
+//> 0: MakeMoveVec<std::string::utf8>([]);
+
+//# programmable --sender A --inputs 1
+//> 0: MakeMoveVec<std::string::utf8>([Input(0)]);

crates/iota-open-rpc/spec/openrpc.json

@@ -1305,6 +1305,7 @@
               "featureFlags": {
                 "accept_zklogin_in_multisig": false,
                 "bridge": false,
+                "convert_type_argument_error": false,
                 "disable_invariant_violation_check_in_swap_loc": true,
                 "disallow_new_modules_in_deps_only_packages": false,
                 "enable_group_ops_native_function_msm": true,

crates/iota-protocol-config/src/lib.rs

@@ -29,7 +29,9 @@ pub const MAX_PROTOCOL_VERSION: u64 = 5;
 // Add `Clock` based unlock to `Timelock` objects.
 // Version 4: Introduce the `max_type_to_layout_nodes` config that sets the
 // maximal nodes which are allowed when converting to a type layout.
-// Version 5: Disallow adding new modules in `deps-only` packages.
+// Version 5: Disallow adding new modules in `deps-only` packages. Enable proper
+// conversion of certain type argument errors in the execution layer using the
+// `convert_type_argument_error` function, which is now used in all cases.
 
 #[derive(Copy, Clone, Debug, Hash, Serialize, Deserialize, PartialEq, Eq, PartialOrd, Ord)]
 pub struct ProtocolVersion(u64);
@@ -198,6 +200,10 @@ struct FeatureFlags {
     // Disallow adding new modules in `deps-only` packages.
     #[serde(skip_serializing_if = "is_false")]
     disallow_new_modules_in_deps_only_packages: bool,
+
+    // Properly convert certain type argument errors in the execution layer.
+    #[serde(skip_serializing_if = "is_false")]
+    convert_type_argument_error: bool,
 }
 
 fn is_true(b: &bool) -> bool {
@@ -1168,6 +1174,10 @@ impl ProtocolConfig {
         POISON_VERSION_METHODS.with(|p| p.load(Ordering::Relaxed))
     }
 
+    pub fn convert_type_argument_error(&self) -> bool {
+        self.feature_flags.convert_type_argument_error
+    }
+
     /// Convenience to get the constants at the current minimum supported
     /// version. Mainly used by client code that may not yet be
     /// protocol-version aware.
@@ -1686,6 +1696,7 @@ impl ProtocolConfig {
                 }
                 5 => {
                     cfg.feature_flags.disallow_new_modules_in_deps_only_packages = true;
+                    cfg.feature_flags.convert_type_argument_error = true;
                 }
                 // Use this template when making changes:
                 //

crates/iota-protocol-config/src/snapshots/iota_protocol_config__test__Mainnet_version_5.snap

@@ -9,6 +9,7 @@ feature_flags:
   zklogin_max_epoch_upper_bound_delta: 30
   relocate_event_module: true
   disallow_new_modules_in_deps_only_packages: true
+  convert_type_argument_error: true
 max_tx_size_bytes: 131072
 max_input_objects: 2048
 max_size_written_objects: 5000000

crates/iota-protocol-config/src/snapshots/iota_protocol_config__test__Testnet_version_5.snap

@@ -9,6 +9,7 @@ feature_flags:
   zklogin_max_epoch_upper_bound_delta: 30
   relocate_event_module: true
   disallow_new_modules_in_deps_only_packages: true
+  convert_type_argument_error: true
 max_tx_size_bytes: 131072
 max_input_objects: 2048
 max_size_written_objects: 5000000

crates/iota-protocol-config/src/snapshots/iota_protocol_config__test__version_5.snap

@@ -13,6 +13,7 @@ feature_flags:
   passkey_auth: true
   relocate_event_module: true
   disallow_new_modules_in_deps_only_packages: true
+  convert_type_argument_error: true
 max_tx_size_bytes: 131072
 max_input_objects: 2048
 max_size_written_objects: 5000000

iota-execution/latest/iota-adapter/src/programmable_transactions/execution.rs

@@ -146,9 +146,13 @@ mod checked {
                         "input checker ensures if args are empty, there is a type specified"
                     );
                 };
-                let elem_ty = context
-                    .load_type(&tag)
-                    .map_err(|e| context.convert_vm_error(e))?;
+                let elem_ty = context.load_type(&tag).map_err(|e| {
+                    if context.protocol_config.convert_type_argument_error() {
+                        context.convert_type_argument_error(0, e)
+                    } else {
+                        context.convert_vm_error(e)
+                    }
+                })?;
                 let ty = Type::Vector(Box::new(elem_ty));
                 let abilities = context
                     .vm
@@ -172,9 +176,13 @@ mod checked {
                 let mut arg_iter = args.into_iter().enumerate();
                 let (mut used_in_non_entry_move_call, elem_ty) = match tag_opt {
                     Some(tag) => {
-                        let elem_ty = context
-                            .load_type(&tag)
-                            .map_err(|e| context.convert_vm_error(e))?;
+                        let elem_ty = context.load_type(&tag).map_err(|e| {
+                            if context.protocol_config.convert_type_argument_error() {
+                                context.convert_type_argument_error(0, e)
+                            } else {
+                                context.convert_vm_error(e)
+                            }
+                        })?;
                         (false, elem_ty)
                     }
                     // If no tag specified, it _must_ be an object