feat(iota-procotol, iota-adapter-tx-tests): Update how we handle type errors in some commands #5664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… errors in some commands
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
iota-ci
added
the
sc-platform
valeriyr
requested changes
Feb 27, 2025
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
|
|
||
| //# init --addresses test=0x0 --accounts A --protocol-version 71 |
There was a problem hiding this comment.
This test should check the behaviour that was before setting the convert_type_argument_error option to true.
So, we need to do the following:
- Change the protocol version to
--protocol-version 4 - Change the file name to
make_vec_non_existent_type_v4.move - Check the expected result.
| @@ -1686,6 +1694,7 @@ impl ProtocolConfig { | |||
| } | |||
| 5 => { | |||
| cfg.feature_flags.disallow_new_modules_in_deps_only_packages = true; | |||
| cfg.feature_flags.convert_type_argument_error = true; | |||
There was a problem hiding this comment.
When we change the protocol configuration, it is necessary to add a description in the following section:
// Record history of protocol version allocations here:
...
// Version 5: Disallow adding new modules in `deps-only` packages.
// Enable proper conversion of certain type argument errors in the execution layer.P.S. We need to check this description when all the related issues are fixed.
muXxer
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Updates handling of type errors for some PTB commands as we were not
properly converting the error type.
Links to any relevant issues
Fixes #5561 .
Type of change
Choose a type of change, and delete any options that are not relevant.