fix(iota): fix Option<address> serialization in client_ptb #5143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
iota-ci
added
dev-tools
DaughterOfMars
approved these changes
Feb 3, 2025
Alex6323
approved these changes
Feb 3, 2025
stefan-mysten
pushed a commit
to MystenLabs/sui
that referenced
this pull request
Feb 11, 2025
# Description of change Handle serialization for Option< address > in a PTB, since `TypeTag` for an Option is a `vector<T>` it needed to be handled extra Porting over iotaledger/iota#5143 ## Type of change - Bug fix (a non-breaking change which fixes an issue) ## How the change has been tested Running this command connected to the testnet ``` cargo run client ptb \ --assign addr "some(@0x2d4b94541bbfcce2ed51e5b0fb73e02bd809e04f1a0601797a6028e6a00b6607)" \ --move-call 0xc9586aae0485f0975167ef0261db81a4011d3255cfa0128dc2f7cc3b72135aaf::example::optional_address_param addr \ --dry-run ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Handle serialization for Option
in a PTB, sinceTypeTagfor an Option is avector<T>it needed to be handled extraLinks to any relevant issues
Fixes #5141
Type of change
How the change has been tested