fix(sui): fix Option<address> serialization in client_ptb #21126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
|
Thanks @Thoralf-M! |
Thoralf-M
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
stefan-mysten
force-pushed
the
option-address-serialization
branch
from
e811617 to
39c6ede
Compare
stefan-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
stefan-mysten
force-pushed
the
option-address-serialization
branch
from
39c6ede to
5632055
Compare
stefan-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
stefan-mysten
force-pushed
the
option-address-serialization
branch
from
5632055 to
52bbc2c
Compare
stefan-mysten
approved these changes
Feb 11, 2025
stefan-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
zeevmoney
added a commit
to dwallet-labs/sui
that referenced
this pull request
Feb 12, 2025
* 'main' of https://github.com/MystenLabs/sui: (84 commits) [Consensus] enable the new linearize logic for devnet. (MystenLabs#21172) Minor change to indicate that GraphQL is at alpha, not at beta (MystenLabs#21169) feat: add zklogin verify endpoint to jsonrpc (MystenLabs#21166) [sui-adapter] Remove error traces from native functions (MystenLabs#21185) [consensus] Enable zstd compression for consensus tonic network in mainnet (MystenLabs#21177) Reduce thread stall log level from ERROR to WARN (MystenLabs#21175) proto: sort fds files for stable codegen rpc: impl Name for google.rpc types rpc: properly return error code rpc: remove reqwest dependency grpc: add protos for more well known types proto: rework directory structure to conform with standards Update publish.mdx (MystenLabs#21170) Update ptb.mdx (MystenLabs#21171) [exp-to-insta][14/14] Cleanup of insta_assert macro (MystenLabs#21114) fix(sui): fix Option<address> serialization in client_ptb (MystenLabs#21126) [exp-to-insta][13/n] Cleanup insta migration (MystenLabs#21113) [exp-to-insta][12/n] Migrate move-analyzer (MystenLabs#21112) [exp-to-insta][11/n] Migrate move-stackless-bytecode and move-model (MystenLabs#21111) [exp-to-insta][10/n] Migrate move-unit-test (MystenLabs#21109) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Handle serialization for Option< address > in a PTB, since
TypeTagfor an Option is avector<T>it needed to be handled extraPorting over iotaledger/iota#5143
Type of change
How the change has been tested
Running this command connected to the testnet