Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tooling-dashboard): improve stake wizard #4454

Conversation

brancoder
Copy link
Contributor

Description of change

resolves #4308

@brancoder brancoder added tooling Issues related to the Tooling team wallet-dashboard Issues related to the Wallet Dashboard dApp labels Dec 11, 2024
@brancoder brancoder requested a review from a team as a code owner December 11, 2024 14:59
@brancoder brancoder linked an issue Dec 11, 2024 that may be closed by this pull request
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 2725997

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-i3xpqtyyp.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 2725997

✅ Preview: https://apps-ui-200wfqh1m-iota1.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 2725997

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-gkfi4x79g.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 2725997

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-aufp45zpu.vercel.app

Copy link
Member

@cpl121 cpl121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another thing that I don't know if it's relevant to this PR, is that all setView have ?., but the prop is not optional
we could update it here, wdyt?

@brancoder brancoder requested a review from cpl121 December 11, 2024 20:01
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: d4f1476

✅ Preview: https://apps-ui-dku29gyb9-iota1.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: d4f1476

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-d6y8wlaeu.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: d4f1476

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-7tmicbjhm.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: d4f1476

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-h4p0bla4b.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: f788ed1

✅ Preview: https://apps-ui-4263vmmjv-iota1.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: f788ed1

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-jjc6w157c.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: f788ed1

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-wkvoj8qkk.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: f788ed1

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-r15d55yxk.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 5d67367

✅ Preview: https://apps-ui-nglo810di-iota1.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 5d67367

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-g2ksnyirk.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 5d67367

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-1dqes190s.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 5d67367

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-2tzt80k80.vercel.app

@evavirseda evavirseda merged commit 21104d3 into tooling-dashboard/add-timelocked-unstake-flow Dec 13, 2024
33 of 34 checks passed
@evavirseda evavirseda deleted the tooling-dashboard/improve-stake-wizzard branch December 13, 2024 07:56
cpl121 added a commit that referenced this pull request Dec 17, 2024
* feat(dashboard): add unstake timelocked objects view

* refactor: improve function

* feat: add more unstaking information and rename constant

* refactor: imports

* fix: imports

* fix: remove duplication collapsible

* refactor: include both single stake and grouped in a unstake hook

* refactor: unify usntake panel

* fix: go back correctly to previous screen in staking

* refactor: cleanup

* refactor: remove popups

* refactor: remove popups

* revert "refactor: remove popups"

* refactor: remove only unnecessary popups

* refactor: divide hooks and move deeper inside components

* fix: resolve re rendering issue

* feat: remove redundant code

* fix: update conditionally showing the stake dialog

* fix(tooling-dashboard): improve stake wizard (#4454)

* fix: improve stake wizzard

* fix: add set view helper function

* fix: add check for stake details

---------

Co-authored-by: evavirseda <evirseda@boxfish.studio>

* refactor: imports / exports

* feat: add wait for transaction and refresh

* feat: improve dialogs

* feat(dashboard): minor fixes

* fix: query key for timelocked staking

* fix: revert constants changes

* fix: disable stake button if no available amount for staking

* fix: query key for timelocked staking transaction

* fix: bigint serialization

* fix: remove or check in the useNewStakeTimelockedTransaction

---------

Co-authored-by: Bran <52735957+brancoder@users.noreply.github.com>
Co-authored-by: evavirseda <evirseda@boxfish.studio>
Co-authored-by: cpl121 <100352899+cpl121@users.noreply.github.com>
Co-authored-by: cpl121 <cpeon@boxfish.studio>
Co-authored-by: Branko <brankobosnic1@gmail.com>
begonaalvarezd pushed a commit that referenced this pull request Dec 18, 2024
* feat(dashboard): add unstake timelocked objects view

* refactor: improve function

* feat: add more unstaking information and rename constant

* refactor: imports

* fix: imports

* fix: remove duplication collapsible

* refactor: include both single stake and grouped in a unstake hook

* refactor: unify usntake panel

* fix: go back correctly to previous screen in staking

* refactor: cleanup

* refactor: remove popups

* refactor: remove popups

* revert "refactor: remove popups"

* refactor: remove only unnecessary popups

* refactor: divide hooks and move deeper inside components

* fix: resolve re rendering issue

* feat: remove redundant code

* fix: add enter amount dialog component

* fix: update conditionally showing the stake dialog

* fix(tooling-dashboard): improve stake wizard (#4454)

* fix: improve stake wizzard

* fix: add set view helper function

* fix: add check for stake details

---------

Co-authored-by: evavirseda <evirseda@boxfish.studio>

* refactor: imports / exports

* feat: add wait for transaction and refresh

* feat: improve dialogs

* feat(dashboard): minor fixes

* fix: query key for timelocked staking

* fix: revert constants changes

* fix: disable stake button if no available amount for staking

* fix: add infoMessage var

* fix: revert pnpm lock changes

---------

Co-authored-by: JCNoguera <88061365+VmMad@users.noreply.github.com>
Co-authored-by: evavirseda <evirseda@boxfish.studio>
Co-authored-by: cpl121 <100352899+cpl121@users.noreply.github.com>
Co-authored-by: cpl121 <cpeon@boxfish.studio>
miker83z pushed a commit that referenced this pull request Dec 20, 2024
* feat(dashboard): add unstake timelocked objects view

* refactor: improve function

* feat: add more unstaking information and rename constant

* refactor: imports

* fix: imports

* fix: remove duplication collapsible

* refactor: include both single stake and grouped in a unstake hook

* refactor: unify usntake panel

* fix: go back correctly to previous screen in staking

* refactor: cleanup

* refactor: remove popups

* refactor: remove popups

* revert "refactor: remove popups"

* refactor: remove only unnecessary popups

* refactor: divide hooks and move deeper inside components

* fix: resolve re rendering issue

* feat: remove redundant code

* fix: update conditionally showing the stake dialog

* fix(tooling-dashboard): improve stake wizard (#4454)

* fix: improve stake wizzard

* fix: add set view helper function

* fix: add check for stake details

---------

Co-authored-by: evavirseda <evirseda@boxfish.studio>

* refactor: imports / exports

* feat: add wait for transaction and refresh

* feat: improve dialogs

* feat(dashboard): minor fixes

* fix: query key for timelocked staking

* fix: revert constants changes

* fix: disable stake button if no available amount for staking

* fix: query key for timelocked staking transaction

* fix: bigint serialization

* fix: remove or check in the useNewStakeTimelockedTransaction

---------

Co-authored-by: Bran <52735957+brancoder@users.noreply.github.com>
Co-authored-by: evavirseda <evirseda@boxfish.studio>
Co-authored-by: cpl121 <100352899+cpl121@users.noreply.github.com>
Co-authored-by: cpl121 <cpeon@boxfish.studio>
Co-authored-by: Branko <brankobosnic1@gmail.com>
miker83z pushed a commit that referenced this pull request Dec 20, 2024
* feat(dashboard): add unstake timelocked objects view

* refactor: improve function

* feat: add more unstaking information and rename constant

* refactor: imports

* fix: imports

* fix: remove duplication collapsible

* refactor: include both single stake and grouped in a unstake hook

* refactor: unify usntake panel

* fix: go back correctly to previous screen in staking

* refactor: cleanup

* refactor: remove popups

* refactor: remove popups

* revert "refactor: remove popups"

* refactor: remove only unnecessary popups

* refactor: divide hooks and move deeper inside components

* fix: resolve re rendering issue

* feat: remove redundant code

* fix: add enter amount dialog component

* fix: update conditionally showing the stake dialog

* fix(tooling-dashboard): improve stake wizard (#4454)

* fix: improve stake wizzard

* fix: add set view helper function

* fix: add check for stake details

---------

Co-authored-by: evavirseda <evirseda@boxfish.studio>

* refactor: imports / exports

* feat: add wait for transaction and refresh

* feat: improve dialogs

* feat(dashboard): minor fixes

* fix: query key for timelocked staking

* fix: revert constants changes

* fix: disable stake button if no available amount for staking

* fix: add infoMessage var

* fix: revert pnpm lock changes

---------

Co-authored-by: JCNoguera <88061365+VmMad@users.noreply.github.com>
Co-authored-by: evavirseda <evirseda@boxfish.studio>
Co-authored-by: cpl121 <100352899+cpl121@users.noreply.github.com>
Co-authored-by: cpl121 <cpeon@boxfish.studio>
jkrvivian pushed a commit that referenced this pull request Jan 6, 2025
* feat(dashboard): add unstake timelocked objects view

* refactor: improve function

* feat: add more unstaking information and rename constant

* refactor: imports

* fix: imports

* fix: remove duplication collapsible

* refactor: include both single stake and grouped in a unstake hook

* refactor: unify usntake panel

* fix: go back correctly to previous screen in staking

* refactor: cleanup

* refactor: remove popups

* refactor: remove popups

* revert "refactor: remove popups"

* refactor: remove only unnecessary popups

* refactor: divide hooks and move deeper inside components

* fix: resolve re rendering issue

* feat: remove redundant code

* fix: update conditionally showing the stake dialog

* fix(tooling-dashboard): improve stake wizard (#4454)

* fix: improve stake wizzard

* fix: add set view helper function

* fix: add check for stake details

---------

Co-authored-by: evavirseda <evirseda@boxfish.studio>

* refactor: imports / exports

* feat: add wait for transaction and refresh

* feat: improve dialogs

* feat(dashboard): minor fixes

* fix: query key for timelocked staking

* fix: revert constants changes

* fix: disable stake button if no available amount for staking

* fix: query key for timelocked staking transaction

* fix: bigint serialization

* fix: remove or check in the useNewStakeTimelockedTransaction

---------

Co-authored-by: Bran <52735957+brancoder@users.noreply.github.com>
Co-authored-by: evavirseda <evirseda@boxfish.studio>
Co-authored-by: cpl121 <100352899+cpl121@users.noreply.github.com>
Co-authored-by: cpl121 <cpeon@boxfish.studio>
Co-authored-by: Branko <brankobosnic1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling Issues related to the Tooling team wallet-dashboard Issues related to the Wallet Dashboard dApp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve stake wizard
3 participants