Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wallet-dashboard): add unstake timelocked objects flow #4300

Merged
merged 39 commits into from
Dec 17, 2024
Merged

feat(wallet-dashboard): add unstake timelocked objects flow #4300

merged 39 commits into from
Dec 17, 2024

Conversation

VmMad
Copy link
Member

@VmMad VmMad commented Nov 28, 2024 •
edited
Loading

Description of change

Fixes #4263

Type of change

  • Enhancement (a non-breaking change which adds functionality)

How the change has been tested

Get a timelocked coin with the sdk, stake one or multiple times, then test the unstaking flow in the Vesting page.

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@VmMad VmMad added tooling Issues related to the Tooling team wallet-dashboard Issues related to the Wallet Dashboard dApp labels Nov 28, 2024
@VmMad VmMad requested review from a team as code owners November 28, 2024 15:48
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 3ed6d5e

✅ Preview: https://apps-ui-r4bic3i8t-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 3ed6d5e

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-n380w1pu2.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 3ed6d5e

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-7khl91e9e.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 3ed6d5e

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-i0eq5wrjd.vercel.app

@VmMad VmMad mentioned this pull request Nov 28, 2024
Closed
cpl121
cpl121 requested changes Dec 4, 2024
View reviewed changes
@github-actions github-actions bot added the explorer Issues related to the Explorer label Dec 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

This pull request has been deployed to Vercel.

Latest commit: 068a798

✅ Preview: https://apps-ui-9dtnaz8cl-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

This pull request has been deployed to Vercel.

Latest commit: 068a798

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-e8b5d0gvn.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

This pull request has been deployed to Vercel.

Latest commit: 068a798

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-3kwcmmol5.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

This pull request has been deployed to Vercel.

Latest commit: 068a798

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-8sp4a5l0h.vercel.app

@VmMad VmMad requested a review from cpl121 December 5, 2024 12:10
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2024

This pull request has been deployed to Vercel.

Latest commit: c70f4f1

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-erpqd9l0j.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2024

This pull request has been deployed to Vercel.

Latest commit: c70f4f1

✅ Preview: https://apps-ui-c0atp1gkw-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2024

This pull request has been deployed to Vercel.

Latest commit: c70f4f1

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-apvhdhb14.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2024

This pull request has been deployed to Vercel.

Latest commit: c70f4f1

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-dk4fla1dw.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2024

This pull request has been deployed to Vercel.

Latest commit: da6de48

✅ Preview: https://apps-ui-n6cvit0nk-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: d2cc8d1

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-1rkby0ldd.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 411d0c9

✅ Preview: https://apps-ui-abalzd7xv-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 411d0c9

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-kte6g2lt0.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 411d0c9

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-c1n2vys0m.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 411d0c9

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-l5a8r2mdo.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 7b3e80b

✅ Preview: https://apps-ui-oov3y313a-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 7b3e80b

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-3lchpg6w1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 7b3e80b

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-hycdrlab9.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 7b3e80b

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-dov84x688.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 29a46ac

✅ Preview: https://apps-ui-628cop6ke-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 29a46ac

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-47h5eiysv.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 29a46ac

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-d0oznmvyj.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 29a46ac

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-cq5381yc6.vercel.app

@begonaalvarezd begonaalvarezd mentioned this pull request Dec 17, 2024
Closed
brancoder
brancoder approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@brancoder brancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: b336b19

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-9rho1dj6s.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: b336b19

✅ Preview: https://apps-ui-p3jm14pan-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: b336b19

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-qglqnr6qs.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: b336b19

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-fnbm7mroh.vercel.app

@cpl121 cpl121 merged commit 619115c into develop Dec 17, 2024
34 of 35 checks passed
@cpl121 cpl121 deleted the tooling-dashboard/add-timelocked-unstake-flow branch December 17, 2024 15:09
miker83z pushed a commit that referenced this pull request Dec 20, 2024
@VmMad @brancoder
@evavirseda @cpl121 @miker83z
feat(wallet-dashboard): add unstake timelocked objects flow (#4300)
cf57cce 
* feat(dashboard): add unstake timelocked objects view

* refactor: improve function

* feat: add more unstaking information and rename constant

* refactor: imports

* fix: imports

* fix: remove duplication collapsible

* refactor: include both single stake and grouped in a unstake hook

* refactor: unify usntake panel

* fix: go back correctly to previous screen in staking

* refactor: cleanup

* refactor: remove popups

* refactor: remove popups

* revert "refactor: remove popups"

* refactor: remove only unnecessary popups

* refactor: divide hooks and move deeper inside components

* fix: resolve re rendering issue

* feat: remove redundant code

* fix: update conditionally showing the stake dialog

* fix(tooling-dashboard): improve stake wizard (#4454)

* fix: improve stake wizzard

* fix: add set view helper function

* fix: add check for stake details

---------

Co-authored-by: evavirseda <evirseda@boxfish.studio>

* refactor: imports / exports

* feat: add wait for transaction and refresh

* feat: improve dialogs

* feat(dashboard): minor fixes

* fix: query key for timelocked staking

* fix: revert constants changes

* fix: disable stake button if no available amount for staking

* fix: query key for timelocked staking transaction

* fix: bigint serialization

* fix: remove or check in the useNewStakeTimelockedTransaction

---------

Co-authored-by: Bran <52735957+brancoder@users.noreply.github.com>
Co-authored-by: evavirseda <evirseda@boxfish.studio>
Co-authored-by: cpl121 <100352899+cpl121@users.noreply.github.com>
Co-authored-by: cpl121 <cpeon@boxfish.studio>
Co-authored-by: Branko <brankobosnic1@gmail.com>
jkrvivian pushed a commit that referenced this pull request Jan 6, 2025
@VmMad @brancoder
@evavirseda @cpl121 @jkrvivian
feat(wallet-dashboard): add unstake timelocked objects flow (#4300)
3d166ba 
* feat(dashboard): add unstake timelocked objects view

* refactor: improve function

* feat: add more unstaking information and rename constant

* refactor: imports

* fix: imports

* fix: remove duplication collapsible

* refactor: include both single stake and grouped in a unstake hook

* refactor: unify usntake panel

* fix: go back correctly to previous screen in staking

* refactor: cleanup

* refactor: remove popups

* refactor: remove popups

* revert "refactor: remove popups"

* refactor: remove only unnecessary popups

* refactor: divide hooks and move deeper inside components

* fix: resolve re rendering issue

* feat: remove redundant code

* fix: update conditionally showing the stake dialog

* fix(tooling-dashboard): improve stake wizard (#4454)

* fix: improve stake wizzard

* fix: add set view helper function

* fix: add check for stake details

---------

Co-authored-by: evavirseda <evirseda@boxfish.studio>

* refactor: imports / exports

* feat: add wait for transaction and refresh

* feat: improve dialogs

* feat(dashboard): minor fixes

* fix: query key for timelocked staking

* fix: revert constants changes

* fix: disable stake button if no available amount for staking

* fix: query key for timelocked staking transaction

* fix: bigint serialization

* fix: remove or check in the useNewStakeTimelockedTransaction

---------

Co-authored-by: Bran <52735957+brancoder@users.noreply.github.com>
Co-authored-by: evavirseda <evirseda@boxfish.studio>
Co-authored-by: cpl121 <100352899+cpl121@users.noreply.github.com>
Co-authored-by: cpl121 <cpeon@boxfish.studio>
Co-authored-by: Branko <brankobosnic1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@begonaalvarezd begonaalvarezd begonaalvarezd left review comments

@panteleymonchuk panteleymonchuk panteleymonchuk approved these changes

@brancoder brancoder brancoder approved these changes

@evavirseda evavirseda evavirseda approved these changes

@cpl121 cpl121 cpl121 approved these changes

Assignees
No one assigned
Labels
explorer Issues related to the Explorer tooling Issues related to the Tooling team wallet-dashboard Issues related to the Wallet Dashboard dApp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Style timelocked unstaking flow
6 participants
@VmMad @begonaalvarezd @panteleymonchuk @brancoder @evavirseda @cpl121