Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL] Release notes for July SYCL implementation update. #291

Merged
merged 3 commits into from
Jul 9, 2019

Conversation

bader
Copy link
Contributor

@bader bader commented Jul 8, 2019

Summary of changes between d404d1c and 64c0262.

Signed-off-by: Alexey Bader <alexey.bader@intel.com>
Copy link
Contributor

@keryell keryell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good.
I have just found 1 typo.

bader added 2 commits July 9, 2019 09:25
Signed-off-by: Alexey Bader <alexey.bader@intel.com>
Signed-off-by: Alexey Bader <alexey.bader@intel.com>
@bader bader merged commit 6abbb56 into intel:sycl Jul 9, 2019
@bader bader deleted the release-notes branch July 10, 2019 05:47
MrSidims added a commit to MrSidims/llvm that referenced this pull request Aug 21, 2019
Last patch is called:
  "Fix invalid .spv->.bc translation of Intel FPGA merge attribute (intel#291)"

Conflicted with:
  "[SYCL] Enable build and LIT tests on windows (intel#463)"
Resolved to "Ours".

Commits excluded from the sync as it breakes SYCL build:
  "Use std::make_unique after LLVM change r369130"
  "Move to C++14"
both of these changes should be cherry-pick after our next LLVM update.

Signed-off-by: Dmitry Sidorov <dmitry.sidorov@intel.com>
bader pushed a commit that referenced this pull request Aug 21, 2019
Last patch is called:
  "Fix invalid .spv->.bc translation of Intel FPGA merge attribute (#291)"

Conflicted with:
  "[SYCL] Enable build and LIT tests on windows (#463)"
Resolved to "Ours".

Commits excluded from the sync as it breakes SYCL build:
  "Use std::make_unique after LLVM change r369130"
  "Move to C++14"
both of these changes should be cherry-pick after our next LLVM update.

Signed-off-by: Dmitry Sidorov <dmitry.sidorov@intel.com>
bb-sycl pushed a commit that referenced this pull request Aug 3, 2021
…shifted

Add a comment when there is a shifted value,
    add x9, x0, #291, lsl #12 ; =1191936
but not when the immediate value is unshifted,
    subs x9, x0, #256 ; =256
when the comment adds nothing additional to the reader.

Differential Revision: https://reviews.llvm.org/D107196
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants