-
Notifications
You must be signed in to change notification settings - Fork 756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL] Release notes for July SYCL implementation update. #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexey Bader <alexey.bader@intel.com>
keryell
reviewed
Jul 8, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks good.
I have just found 1 typo.
Signed-off-by: Alexey Bader <alexey.bader@intel.com>
Signed-off-by: Alexey Bader <alexey.bader@intel.com>
Ruyk
reviewed
Jul 9, 2019
Fznamznon
approved these changes
Jul 9, 2019
MrSidims
added a commit
to MrSidims/llvm
that referenced
this pull request
Aug 21, 2019
Last patch is called: "Fix invalid .spv->.bc translation of Intel FPGA merge attribute (intel#291)" Conflicted with: "[SYCL] Enable build and LIT tests on windows (intel#463)" Resolved to "Ours". Commits excluded from the sync as it breakes SYCL build: "Use std::make_unique after LLVM change r369130" "Move to C++14" both of these changes should be cherry-pick after our next LLVM update. Signed-off-by: Dmitry Sidorov <dmitry.sidorov@intel.com>
bader
pushed a commit
that referenced
this pull request
Aug 21, 2019
Last patch is called: "Fix invalid .spv->.bc translation of Intel FPGA merge attribute (#291)" Conflicted with: "[SYCL] Enable build and LIT tests on windows (#463)" Resolved to "Ours". Commits excluded from the sync as it breakes SYCL build: "Use std::make_unique after LLVM change r369130" "Move to C++14" both of these changes should be cherry-pick after our next LLVM update. Signed-off-by: Dmitry Sidorov <dmitry.sidorov@intel.com>
bb-sycl
pushed a commit
that referenced
this pull request
Aug 3, 2021
…shifted Add a comment when there is a shifted value, add x9, x0, #291, lsl #12 ; =1191936 but not when the immediate value is unshifted, subs x9, x0, #256 ; =256 when the comment adds nothing additional to the reader. Differential Revision: https://reviews.llvm.org/D107196
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes between d404d1c and 64c0262.