Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include cl_ext.h instead of deprecated cl_ext_intel.h #67

Merged
merged 2 commits into from
Jan 25, 2022

Conversation

pcolberg
Copy link
Contributor

@pcolberg pcolberg commented Jan 24, 2022

Note that opencl.h already includes cl_ext.h

This resolves warnings introduced with the OpenCL headers update.

#62

../include/CL/cl_ext_intel.h:19:105: note: #pragma message: The Intel extensions have been moved into cl_ext.h.  Please include cl_ext.h directly.
 #pragma message("The Intel extensions have been moved into cl_ext.h.  Please include cl_ext.h directly.")

Closes #66

@pcolberg pcolberg added this to the 2022.3 milestone Jan 24, 2022
@pcolberg pcolberg requested a review from zibaiwan January 24, 2022 23:53
@pcolberg pcolberg self-assigned this Jan 24, 2022
@pcolberg pcolberg force-pushed the fix-opencl-warnings branch from 853d4a8 to 99c78d7 Compare January 25, 2022 00:02
Note that opencl.h already includes cl_ext.h

This resolves warnings introduced with the OpenCL headers update.

intel#62

../include/CL/cl_ext_intel.h:19:105: note: #pragma message: The Intel extensions have been moved into cl_ext.h.  Please include cl_ext.h directly.
 #pragma message("The Intel extensions have been moved into cl_ext.h.  Please include cl_ext.h directly.")

Closes intel#66
../../include/CL/cl_version.h:22:104: note: #pragma message: cl_version.h: CL_TARGET_OPENCL_VERSION is not defined. Defaulting to 300 (OpenCL 3.0)
 #pragma message("cl_version.h: CL_TARGET_OPENCL_VERSION is not defined. Defaulting to 300 (OpenCL 3.0)")
@pcolberg pcolberg force-pushed the fix-opencl-warnings branch from 99c78d7 to 401fadd Compare January 25, 2022 00:05
Copy link
Contributor

@zibaiwan zibaiwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks @pcolberg

@pcolberg pcolberg merged commit 1264543 into intel:main Jan 25, 2022
@pcolberg pcolberg deleted the fix-opencl-warnings branch January 25, 2022 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intel extensions have been moved into cl_ext.h
2 participants