Sync Khronos OpenCL-Header cl_intel_mem_alloc_buffer_location extension #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Great upstream work, Sherry 🙂 Instead of copying only the new |
Sure! I will sync everything. |
|
The sync is complete. A caveat: one of the files we currently have does not exist in khronos registry. I feel like we might not want to push these to khronos, but at the same time we do not want to have our own enum that potentially will conflict with future khronos headers. Things in this file need to be updated periodically. |
|
Thanks Sherry. Could you set the modes of the files back to non-executable ( |
pcolberg
reviewed
Jan 20, 2022
pcolberg
reviewed
Jan 20, 2022
sherry-yuan
force-pushed
the
khr-header
branch
from
4a8c2f2 to
4274b47
Compare
KhronosGroup/OpenCL-Headers@80c10b1 cl_ext_intelfpga does not exist in ocl header but is still added in this repo because it is needed in profilers etc. This file potentially need to be updated once a while to avoid conflict with khronos header. Upgrade default version to opencl core 3.0. This will not break existing functionality because we are currently already building with 3.0 (see CMakeLists.txt). All future version of opencl core is backward compatible.
clEnqueueWriteBufferRect function's parameter name changed in newly synced khronos header. Need to change source files as well
|
Thanks @sherry-yuan! I pushed a minor revision that reverts the executable bit on |
pcolberg
approved these changes
Jan 20, 2022
pcolberg
added a commit
to pcolberg/fpga-runtime-for-opencl
that referenced
this pull request
Jan 24, 2022
This resolves warnings introduced with the OpenCL headers update. intel#62 ../include/CL/cl_ext_intel.h:19:105: note: #pragma message: The Intel extensions have been moved into cl_ext.h. Please include cl_ext.h directly. #pragma message("The Intel extensions have been moved into cl_ext.h. Please include cl_ext.h directly.") Closes intel#66
pcolberg
added a commit
to pcolberg/fpga-runtime-for-opencl
that referenced
this pull request
Jan 25, 2022
Note that opencl.h already includes cl_ext.h This resolves warnings introduced with the OpenCL headers update. intel#62 ../include/CL/cl_ext_intel.h:19:105: note: #pragma message: The Intel extensions have been moved into cl_ext.h. Please include cl_ext.h directly. #pragma message("The Intel extensions have been moved into cl_ext.h. Please include cl_ext.h directly.") Closes intel#66
pcolberg
added a commit
to pcolberg/fpga-runtime-for-opencl
that referenced
this pull request
Jan 25, 2022
Note that opencl.h already includes cl_ext.h This resolves warnings introduced with the OpenCL headers update. intel#62 ../include/CL/cl_ext_intel.h:19:105: note: #pragma message: The Intel extensions have been moved into cl_ext.h. Please include cl_ext.h directly. #pragma message("The Intel extensions have been moved into cl_ext.h. Please include cl_ext.h directly.") Closes intel#66
pcolberg
added a commit
that referenced
this pull request
Jan 25, 2022
Note that opencl.h already includes cl_ext.h This resolves warnings introduced with the OpenCL headers update. #62 ../include/CL/cl_ext_intel.h:19:105: note: #pragma message: The Intel extensions have been moved into cl_ext.h. Please include cl_ext.h directly. #pragma message("The Intel extensions have been moved into cl_ext.h. Please include cl_ext.h directly.") Closes #66
pcolberg
added a commit
to pcolberg/fpga-runtime-for-opencl
that referenced
this pull request
Jan 28, 2022
This amends intel#62
pcolberg
added a commit
to pcolberg/fpga-runtime-for-opencl
that referenced
this pull request
Jan 28, 2022
This amends intel#62
pcolberg
added a commit
to pcolberg/fpga-runtime-for-opencl
that referenced
this pull request
Jan 28, 2022
This amends intel#62 OpenCL layers are an experimental feature which we don't use, but there is no downside to installing the header for the sake of completeness. https://github.com/KhronosGroup/OpenCL-ICD-Loader/blob/cd7d07cfa667d8d959b4272be45cf217a65c2948/README.md#about-layers
pcolberg
added a commit
that referenced
this pull request
Jan 28, 2022
This amends #62 OpenCL layers are an experimental feature which we don't use, but there is no downside to installing the header for the sake of completeness. https://github.com/KhronosGroup/OpenCL-ICD-Loader/blob/cd7d07cfa667d8d959b4272be45cf217a65c2948/README.md#about-layers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done to align with buffer location opencl extension in https://github.com/KhronosGroup/OpenCL-Headers/blob/80c10b1f65b932894b830da7cd37bc56c541bae4/CL/cl_ext.h#L2350-L2361
This extension allows user to specify which device global memory the memory should be allocated to.