Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change size_t printf statement to %zu #238

Merged
merged 1 commit into from
Jan 9, 2023
Merged

Change size_t printf statement to %zu #238

merged 1 commit into from
Jan 9, 2023

Conversation

IlanTruanovsky
Copy link
Contributor

@IlanTruanovsky IlanTruanovsky commented Jan 9, 2023 •
edited
Loading

This change fixes this Coverity issue:
src/acl_offline_hal.cpp:182:69:
Type: Invalid type in argument to printf format specifier (PRINTF_ARGS)

@IlanTruanovsky IlanTruanovsky self-assigned this Jan 9, 2023
@IlanTruanovsky IlanTruanovsky added the bug Something isn't working label Jan 9, 2023
@IlanTruanovsky IlanTruanovsky added this to the 2023.2 milestone Jan 9, 2023
@zibaiwan zibaiwan self-requested a review January 9, 2023 18:13
zibaiwan
zibaiwan requested changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@zibaiwan zibaiwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ilan, based on the resolved discussion in #221.

We should use %zu for the size_t type.

@IlanTruanovsky
Change integer printf statement to size_t type
43603d6 
This change fixes this coverity issue:
src/acl_offline_hal.cpp:182:69:
  Type: Invalid type in argument to printf format specifier (PRINTF_ARGS)
@zibaiwan zibaiwan changed the title Change integer printf statement to unsigned long Change size_t printf statement to %zu Jan 9, 2023
@zibaiwan zibaiwan merged commit 220f560 into intel:main Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zibaiwan zibaiwan zibaiwan approved these changes

Assignees

@IlanTruanovsky IlanTruanovsky

Labels
bug Something isn't working
Projects
None yet
Milestone
2023.2
Development

Successfully merging this pull request may close these issues.
2 participants
@IlanTruanovsky @zibaiwan