Fixed coverity issues in src/acl_kernel.cpp #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcolberg
requested changes
Dec 5, 2022
haoxian2
force-pushed
the
coverity-acl-kernel
branch
from
96d1a9a to
fb3beb6
Compare
pcolberg
previously approved these changes
Dec 7, 2022
…t to printf format specifier (PRINTF_ARGS) `local_work_size[idim]` is of type `size_t` therefore using `%zu` instead of `%d`.
…riable (UNINIT) Function `l_copy_and_adjust_arguments_for_device` at `line 2164` uses `memory_migration.num_mem_objects`, but `memory_migration` has only been declared up until this point. I assume that since there has been no changes to `memory_migration`, upon declaration, the `num_mem_objects` should be set to 0. This assumption is reinforced by the second occurrence of `l_copy_and_adjust_arguments_for_device` at `line 2228` where `memory_migration.num_mem_objects = 0` is been initialized a few lines before.
pcolberg
force-pushed
the
coverity-acl-kernel
branch
from
fb3beb6 to
96d1a9a
Compare
pcolberg
previously approved these changes
Dec 7, 2022
pcolberg
force-pushed
the
coverity-acl-kernel
branch
from
96d1a9a to
2532834
Compare
pcolberg
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed coverity issue in acl_kernel.cpp: Type: Invalid type in argument to printf format specifier (PRINTF_ARGS)
local_work_size[idim]is of typesize_ttherefore using%zuinstead of%d.Fixed coverity issue in acl_kernel.cpp: Type: Uninitialized scalar variable (UNINIT)
Function
l_copy_and_adjust_arguments_for_deviceatline 2164usesmemory_migration.num_mem_objects, butmemory_migrationhas only been declared up until this point. I assume that since there has been no changes tomemory_migration, upon declaration, thenum_mem_objectsshould be set to 0. This assumption is reinforced by the second occurrence ofl_copy_and_adjust_arguments_for_deviceatline 2228wherememory_migration.num_mem_objects = 0is been initialized a few lines before.