chore(kv): delete deprecated kv service code #19783
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeorgeMac
commented
Oct 20, 2020
| @@ -133,41 +134,23 @@ func (s *Service) findTaskByID(ctx context.Context, tx Tx, id influxdb.ID) (*inf | |||
| t.LatestCompleted = t.CreatedAt | |||
| } | |||
|
|
|||
| // Attempt to fill in the owner ID based on the auth. | |||
There was a problem hiding this comment.
note for reader:
https://github.com/influxdata/influxdb/blob/master/kv/migration/all/0003_task_owners.go#L15
This should not be nil anymore as a migration was delivered to backfill missing owners a while ago.
GeorgeMac
commented
Oct 20, 2020
| @@ -863,12 +815,6 @@ func (s *Service) deleteTask(ctx context.Context, tx Tx, id influxdb.ID) error { | |||
| return influxdb.ErrUnexpectedTaskBucketErr(err) | |||
| } | |||
|
|
|||
| if err := s.deleteUserResourceMapping(ctx, tx, influxdb.UserResourceMappingFilter{ | |||
There was a problem hiding this comment.
We don't create URMs anymore for tasks (like this anyway). So we don't need this.
This may leave some dangling URMs, but they are harmless cruft.
This includes removal of a lot of kv.Service responsibilities. However, it does not finish the re-wiring. It removes documents, telegrafs, notification rules + endpoints, checks, orgs, users, buckets, passwords, urms, labels and authorizations. There are some oustanding pieces that are needed to get kv service compiling (dashboard service urm dependency). Then all the call sites for kv service need updating and the new implementations of telegraf and notification rules + endpoints needed installing (along with any necessary migrations).
GeorgeMac
force-pushed
the
gm/kv-service-tenant-removal
branch
from
00b9c98 to
c32b20f
Compare
This was referenced Oct 22, 2020
4 tasks
|
Second pass: #19878 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18498
This includes removal of a lot of kv.Service responsibilities. However,
it does not finish the re-wiring.
It removes:
There are some outstanding pieces that are needed to get kv service compiling (dashboard service urm dependency). Then all the call sites for kv service need updating and the new implementations of telegraf and notification rules + endpoints needed installing (along with any necessary migrations).