Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Notification Rule service into own package #19798

Closed
GeorgeMac opened this issue Oct 22, 2020 · 0 comments · Fixed by #19804
Closed

Move Notification Rule service into own package #19798

GeorgeMac opened this issue Oct 22, 2020 · 0 comments · Fixed by #19804
Assignees
@GeorgeMac
Labels
kind/refactor team/compute
Milestone
Sprint 20-Q4-2

Comments

@GeorgeMac
Copy link
Contributor

In order to support #19783

We need to isolate notification rule service definitions into own package (outside kv) and remove URM interactions.
This also works towards our endeavors to better isolate services from one another.

I have an implementation in the pipeline. This issue is for reference for the compute teams records and for organizing timeline.

Success Criteria

  • We can rebase the referenced PR and remove need for *kv.Service to implement notification rule service.
  • Further isolation of tenant responsibilities in the tenant service.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GeorgeMac GeorgeMac

Labels
kind/refactor team/compute
Projects
None yet
Milestone
Sprint 20-Q4-2
Development

Successfully merging a pull request may close this issue.

refactor(notification): move rule service into own package influxdata/influxdb
1 participant
@GeorgeMac