feat(upgrade): upgrade config #19646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
alespour
force-pushed
the
feat/upgrade-config
branch
from
bfb6686 to
80e3d03
Compare
alespour
force-pushed
the
feat/upgrade-config
branch
from
80e3d03 to
f3286f3
Compare
alespour
force-pushed
the
feat/upgrade-config
branch
from
f3286f3 to
7dd3b91
Compare
stuartcarnie
requested changes
Oct 1, 2020
There was a problem hiding this comment.
Overall this PR looks great and I like the simplicity of a simple mapping that has been used. Great to see tests verifying the transformations 🎉
It is unclear why the rules are encoded in JSON and then embedded using go-bindata and then later unmarshaled. Could you explain the reasoning behind this approach?
alespour
force-pushed
the
feat/upgrade-config
branch
from
7dd3b91 to
819b2e3
Compare
alespour
force-pushed
the
feat/upgrade-config
branch
from
819b2e3 to
225500f
Compare
stuartcarnie
approved these changes
Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is 3rd PR of 4 for the upgrade feature.
Upgrades config to 2.x format.
It is branched from PR #19641 which should be merged first to avoid conflicts.