-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(upgrade): upgrade security #19651
feat(upgrade): upgrade security #19651
Conversation
10d598b
to
1f4225e
Compare
84f78d4
to
5326034
Compare
95c7bad
to
6234a9c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking really good! I have mostly nits to correct and a couple of questions.
bce296d
to
c18ce8f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks great – just one more change and we can get this merged!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit for the help of the influx-command-path
and then we can merge it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great – thank you!
@alespour can you rebase your PR on master, as I see other commits to master are passing. |
e07513d
to
fda77e9
Compare
This is 4th PR of 4 for the upgrade feature.
Generates script which upgrades users to 2.x. The script uses
influx
tool to create tokens with read/write permission to buckets that were created for 1.x databases. A token represents 1.x user, 1.x user name becomes the description of the token.Note: It is branched from PR #19641 which should be merged first to avoid conflicts.