Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(upgrade): upgrade security #19651

Merged
merged 3 commits into from
Oct 14, 2020

Conversation

alespour
Copy link
Contributor

@alespour alespour commented Sep 28, 2020

This is 4th PR of 4 for the upgrade feature.
Generates script which upgrades users to 2.x. The script uses influx tool to create tokens with read/write permission to buckets that were created for 1.x databases. A token represents 1.x user, 1.x user name becomes the description of the token.

Note: It is branched from PR #19641 which should be merged first to avoid conflicts.

@alespour alespour requested a review from rogpeppe September 28, 2020 11:34
@alespour alespour marked this pull request as ready for review September 28, 2020 11:35
@alespour alespour force-pushed the feat/upgrade-security branch from 10d598b to 1f4225e Compare September 29, 2020 09:40
@alespour alespour marked this pull request as draft September 29, 2020 15:47
@alespour alespour removed the request for review from rogpeppe September 29, 2020 16:06
@alespour alespour force-pushed the feat/upgrade-security branch 2 times, most recently from 84f78d4 to 5326034 Compare October 2, 2020 10:37
@alespour alespour marked this pull request as ready for review October 2, 2020 11:05
@alespour alespour force-pushed the feat/upgrade-security branch 2 times, most recently from 95c7bad to 6234a9c Compare October 2, 2020 15:50
Copy link
Contributor

@stuartcarnie stuartcarnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking really good! I have mostly nits to correct and a couple of questions.

@alespour alespour force-pushed the feat/upgrade-security branch 4 times, most recently from bce296d to c18ce8f Compare October 13, 2020 08:55
Copy link
Contributor

@stuartcarnie stuartcarnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great – just one more change and we can get this merged!

Copy link
Contributor

@stuartcarnie stuartcarnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit for the help of the influx-command-path and then we can merge it

Copy link
Contributor

@stuartcarnie stuartcarnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great – thank you!

@stuartcarnie
Copy link
Contributor

@alespour can you rebase your PR on master, as I see other commits to master are passing.

@alespour alespour force-pushed the feat/upgrade-security branch from e07513d to fda77e9 Compare October 14, 2020 12:23
@stuartcarnie stuartcarnie merged commit 8a00685 into influxdata:master Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants