fix: Map type Variables selector shows keys, not values #15354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
ebb-tide
reviewed
Oct 8, 2019
|
|
||
| expect(dropdownItems.length).toBe(Object.keys(values).length) | ||
| expect(dropdownItems).toEqual(Object.keys(values)) |
ebb-tide
reviewed
Oct 8, 2019
| fireEvent.click(getByLabelText('Value')) | ||
| fireEvent.click(getByTestId('dropdown--button')) | ||
| Object.keys(variableValues).forEach(variableKey => { | ||
| expect(getByText(variableKey)).toBeTruthy() |
ebb-tide
requested review from
zoesteinkamp
and removed request for
zoesteinkamp
|
Thanks y'all! |
hoorayimhelping
changed the title
hoorayimhelping
force-pushed
the
bucky_variable_show_keys
branch
from
6dbcbda to
fb65f5c
Compare
hoorayimhelping
changed the title
hoorayimhelping
changed the title
add test for hydrateVars dashboard variable dropdown test: inspect values, not just array length add RTL test for variable dropdown changes lint fix: Disable saving threshold check if no threshold selected (#15348) * Prevent check saving if no thresholds * Add tests * Add changes to changelog * make optional props optional * use false instead of null for boolean changelog fix(ui): ignore false change events in VariableForm (#15317) closes #15059 the issue is to persist user data across variable type selection interfaces within the variable editor. this commit pushes all of the variable editor information down to redux to allow persistence outside of the view state until the user clicks "cancel" or "create" in the interface.
hoorayimhelping
force-pushed
the
bucky_variable_show_keys
branch
from
fb65f5c to
78244ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14054
Map variable types are key-value pairs. Previously, the dashboard variable dropdown showed the keys (correct behavior), but the query variable dropdown would show values. Both now show keys.
Testing instructions (assuming you have variables):