Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save as Variable: Save the query when selection other variable types (map, csv) #15059

Closed
russorat opened this issue Sep 9, 2019 · 0 comments · Fixed by #15317
Closed

Save as Variable: Save the query when selection other variable types (map, csv) #15059

russorat opened this issue Sep 9, 2019 · 0 comments · Fixed by #15317
Assignees
@drdelambre
Labels
kind/bug

Comments

@russorat
Copy link
Contributor

russorat commented Sep 9, 2019 •
edited
Loading

as a user
when i decide to save my query as a variable and select other variable types
then i would like my query to be saved so that when i switch back to it, i don't lose it

variable
@drdelambre drdelambre self-assigned this Oct 4, 2019
drdelambre pushed a commit that referenced this issue Oct 4, 2019
fix(ui): ignore false change events in VariableForm
2ae6a75 
closes #15059

if a user re-selects the same variable type when adding a variable, no action takes place
@drdelambre drdelambre mentioned this issue Oct 4, 2019
Merged
drdelambre added a commit that referenced this issue Oct 8, 2019
@drdelambre
fix(ui): ignore false change events in VariableForm (#15317)
99478fe 
closes #15059

the issue is to persist user data across variable type selection interfaces within the variable editor. this commit pushes all of the variable editor information down to redux to allow persistence outside of the view state until the user clicks "cancel" or "create" in the interface.
hoorayimhelping pushed a commit that referenced this issue Oct 8, 2019
@drdelambre @hoorayimhelping
fix(ui): ignore false change events in VariableForm (#15317)
130a375 
closes #15059

the issue is to persist user data across variable type selection interfaces within the variable editor. this commit pushes all of the variable editor information down to redux to allow persistence outside of the view state until the user clicks "cancel" or "create" in the interface.
hoorayimhelping added a commit that referenced this issue Oct 8, 2019
@hoorayimhelping
fix: Map type Variables selector shows keys, not values
78244ce 
add test for hydrateVars

dashboard variable dropdown test: inspect values, not just array length

add RTL test for variable dropdown changes

lint

fix: Disable saving threshold check if no threshold selected (#15348)

* Prevent check saving if no thresholds

* Add tests

* Add changes to changelog

* make optional props optional

* use false instead of null for boolean

changelog

fix(ui): ignore false change events in VariableForm (#15317)

closes #15059

the issue is to persist user data across variable type selection interfaces within the variable editor. this commit pushes all of the variable editor information down to redux to allow persistence outside of the view state until the user clicks "cancel" or "create" in the interface.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drdelambre drdelambre

Labels
kind/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui): ignore false change events in VariableForm influxdata/influxdb
2 participants
@drdelambre @russorat