Add 1170 pads and select impls for HAL 0.5 #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 tasks
mciantyre
force-pushed
the
iomuxc-from-svd
branch
from
d8b0f86 to
6bf8ceb
Compare
Still usable with the EH02 HAL traits; just need to look at it differently. This lets us define an ADC driver that more closely resembles other peripheral drivers.
Some pins on the 1170 support two different GPIO modules. We couldn't express that with the previous trait. This commit moves the module number into a const generic argument so that the same pad can implement multiple pin traits. This removes the gpio::Pin trait bound on ADC, for convenience. It doesn't seem like we need this bound; see inline notes.
Derived from the 1176 CM7 SVD. The pad definitions are exactly the same in the CM4 SVD; confirmed by piping the iomuxc output into shasum and comparing the checksums for the CM7- and CM4-based outputs.
This is incomplete. It's just enough to enable the debug console on the 1170 EVK.
Just enough support for very basic examples in imxrt-hal.
See previous commit for more context. Check for IOMUXC_LPSR, and parse the daisy registers in that peripheral block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds types and accessors for 1170 pads. It includes select pin implementations for those pads. There's just enough pin implementations to support the examples bundled with the proposed 0.5 HAL.
The PR changes the
gpio::Pintrait. Some 1170 pads can be muxed to different GPIO peripherals, and the previous trait couldn't express that capability. This is a breaking change that also affects the 1010 and 1060 pins.Finally, the PR introduces a CCM pin trait. CCMs can output clock frequencies on a pad, and the pin trait describes which pins support that feature. There's a 0.5 HAL example that uses this for testing clock frequencies.
This PR depends on #23.