Generate pads from SVD #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends on #22. |
mciantyre
commented
Jan 2, 2022
Comment on lines
+2152
to
+2153
| pub gpio_spi_b0: gpio_spi_b0::Pads, | ||
| pub gpio_spi_b1: gpio_spi_b1::Pads, |
There was a problem hiding this comment.
Note that the 1060 has two new pad groups. I've not found direct mention of these pads in the 1060 reference manual, but they seem to be in the SVDs.
mciantyre
force-pushed
the
iomuxc-from-svd
branch
from
97a4aa0 to
d8b0f86
Compare
18 tasks
Tested throughout the 0.5 HAL development. |
All tests pass, so the new implementation appears to be API compatible.
Generate pad definitions from the SVDs using iomuxc.py.
Demonstrates the fix for the backwards 1010 pads. The tests now run all the time, and they pass.
mciantyre
force-pushed
the
iomuxc-from-svd
branch
from
d8b0f86 to
6bf8ceb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR proposes that we generate pad definitions from the SVD. We use a Python script to generate the pads, and we check in the code. The approach replaces the build script and code generation library that also generated the pads, but relied on human oversight instead of the SVD.
The PR includes new definitions for the 1060 and 1010 pads. I only tested with this crate's test suite. It should be API compatible with the code that was previously generated. I'll move this out of draft once I can test a bit on my 1060 hardware.
The PR enables the tests introduced in #21. It fixes #11.
Python made it easy to prototype and implement. We could also consider re-using parts of the build script library; we would need an XML / SVD parser, and to re-think the data structures that the codegen uses.