Refactoring of ThermalGrid.handleInfeed to fix thermal storage recharge correctly when empty
#931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…neState-of-ThermalHouse' into df/tmpHPmergeall
…ageResults-have-multiple-entries' into df/tmpHPmergeall # Conflicts: # CHANGELOG.md
…ion-of-Hp-when-not-under-control-of-an-EM' into df/tmpHPmergeall # Conflicts: # CHANGELOG.md
…ermalGird-energyDemand' into df/tmpHPmergeall
…ge correctly when empty
# Conflicts: # CHANGELOG.md # src/main/scala/edu/ie3/simona/model/thermal/ThermalGrid.scala
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md # src/main/scala/edu/ie3/simona/model/thermal/ThermalGrid.scala
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
…refactor-handleInfeed
This reverts commit a669b5b.
…ctor-handleInfeed
…ctor-handleInfeed
# Conflicts: # CHANGELOG.md
# Conflicts: # src/test/scala/edu/ie3/simona/agent/em/EmAgentIT.scala
Signed-off-by: Sebastian Peter <sebastian.peter@tu-dortmund.de>
Signed-off-by: Sebastian Peter <sebastian.peter@tu-dortmund.de>
sebastian-peter
requested changes
Feb 4, 2025
Comment on lines
239
to
246
| (zeroKW, lastStateStorageQDot * (-1)) | ||
| else if ( | ||
| lastStateStorageQDot == zeroKW && (demandWrapper.houseDemand.hasRequiredDemand || demandWrapper.heatStorageDemand.hasRequiredDemand) | ||
| ) | ||
| ( | ||
| zeroKW, | ||
| thermalGrid.storage.map(_.getChargingPower: squants.Power).get, | ||
| ) |
There was a problem hiding this comment.
Thanks for adding this large amount of commentary to the code! I have only two more places with "additional documentation demand" ;)
About storages: I guess one could argue about the required demand for empty storage (what if it's filled with a mWh of energy - there'd be no required demand). But, I'd suggest to just document the way this is currently implemented. Maybe it makes sense to enhance the documentation of ThermalDemandWrapper.heatStorageDemand in that regard?
Furthermore, ScalaDoc for ThermalStorageState would be great. Questions about the sign/direction of its qDot would be solved then.
…nto df/#930-refactor-handleInfeed
…ecking for conditions within HpModel.calculateHeat
…eInfeed # Conflicts: # CHANGELOG.md
Signed-off-by: Sebastian Peter <sebastian.peter@tu-dortmund.de>
sebastian-peter
approved these changes
Feb 6, 2025
This was referenced Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #930
merge #1052 and #1046 and #1128 first