Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor thermal calcRelevantData #1052

Merged
merged 7 commits into from
Nov 26, 2024

Conversation

danielfeismann
Copy link
Member

resolves #1051

@danielfeismann danielfeismann self-assigned this Nov 24, 2024
@danielfeismann danielfeismann added the code quality Code readability or efficiency is improved label Nov 24, 2024
# Conflicts:
#	CHANGELOG.md
#	src/main/scala/edu/ie3/simona/model/participant/HpModel.scala
#	src/main/scala/edu/ie3/simona/model/thermal/ThermalGrid.scala
#	src/test/scala/edu/ie3/simona/model/thermal/ThermalGridWithHouseAndStorageSpec.scala
#	src/test/scala/edu/ie3/simona/model/thermal/ThermalGridWithHouseOnlySpec.scala
#	src/test/scala/edu/ie3/simona/model/thermal/ThermalGridWithStorageOnlySpec.scala
@danielfeismann danielfeismann marked this pull request as ready for review November 25, 2024 16:23
Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks

@sebastian-peter sebastian-peter merged commit e420a54 into dev Nov 26, 2024
4 checks passed
@danielfeismann danielfeismann deleted the df/#1051-Refactor-thermal-calcRelevantData branch November 26, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Code readability or efficiency is improved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor thermal calcRelevantData
2 participants