Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore tOptions typing needed for the ICU plugin #634

Closed
wants to merge 1 commit into from
Closed

Restore tOptions typing needed for the ICU plugin #634

wants to merge 1 commit into from

Conversation

kachkaev
Copy link
Contributor

@kachkaev kachkaev commented Dec 4, 2018

This PR restores tOptions prop, which was lost while migrating from DefinitelyTypes typings. See #557 and DefinitelyTyped/DefinitelyTyped#29945 (file types/react-i18next/src/trans.d.ts).

cc @schettino

@jamuhl jamuhl requested a review from schettino December 4, 2018 10:21
@coveralls
Copy link

Coverage Status

Coverage remained the same at 74.448% when pulling ab8188f on kachkaev:patch-1 into 458d242 on i18next:master.

@kachkaev
Copy link
Contributor Author

kachkaev commented Dec 6, 2018

Looks like <Trans i18nKey="smth" values={{x: 42}} /> works just like <Trans i18nKey="smth" tOptions={{x: 42}} />. Shall we close this PR then?

@jamuhl
Copy link
Member

jamuhl commented Dec 15, 2018

closing like you mention using values is nicer

@jamuhl jamuhl closed this Dec 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schettino schettino Awaiting requested review from schettino

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kachkaev @coveralls @jamuhl