-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Type Definitions #557
Conversation
1 similar comment
Awesome. Thanks a lot. Was published with react-i18next@8.1.0 Hope i will remember pinging you in case we need to change the definitions - will need to start remembering this. |
Anytime @jamuhl. I'll be looking at the issues in case of something related to the typings comes up, and new releases as well. Thanks |
Is anyone deprecating DT typings https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/react-i18next already? |
I'll file a PR against DT. |
These have been released upstream as of react-i18next 8.1.0. See i18next/react-i18next#557. Closes DefinitelyTyped#29408 Closes DefinitelyTyped#29480 Closes DefinitelyTyped#29685 Closes DefinitelyTyped#29807
The upstream library now ships it's own as of react-i18next 8.1.0. See i18next/react-i18next#557. Closes DefinitelyTyped#29408 Closes DefinitelyTyped#29480 Closes DefinitelyTyped#29685 Closes DefinitelyTyped#29807
@schettino Thanks for doing this! |
I'm getting the following error after upgrading to use the type definitions from 8.1.0.
I have the latest |
@schettino, first off - thank you for adding typescript definitions! I have just updated to v8.1.0 to get your typescript defs, however I am running into this error: This is caused by something like:
I am fairly new to Typescript, but is this syntax expected to be supported by the Typescript definitions? It is the syntax used in the react-i18next docs. |
@chillitom The types are written in such a way that it requires the compiler option |
@jchu231 @mgroenhoff please create a new issue if having problem - adding comments to closed PR might risk that gets under the table (forgotten) |
For future releases, feel free to ping me to get the typings updated
Resolves: #550
This PR adds the typescript type definitions.
hoc usage