Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explorer; fix dims without coords crash #1334

Merged
merged 2 commits into from
May 2, 2024
Merged

Conversation

ahuang11
Copy link
Collaborator

Closes #1272

@ahuang11 ahuang11 requested a review from maximlt April 30, 2024 14:57
Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.38%. Comparing base (e5e71d6) to head (65c91b1).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1334      +/-   ##
==========================================
+ Coverage   87.36%   87.38%   +0.01%     
==========================================
  Files          50       50              
  Lines        7471     7481      +10     
==========================================
+ Hits         6527     6537      +10     
  Misses        944      944              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@maximlt maximlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maximlt maximlt merged commit f7f2d1c into main May 2, 2024
9 of 10 checks passed
@maximlt maximlt deleted the fix_dims_without_coords branch May 2, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ValueError when trying to display a netCDF file with the explorer
2 participants