Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport] [Resolved : limiter float too generic] #8

Merged
merged 6 commits into from
Jun 6, 2018

Conversation

hitesh-wagento
Copy link
Owner

Original Pull Request

magento#15878

.limiter should have the same parent selectors like .pages to prevent clashes between styles and layouts

Description

Added selector for floating the element .limiter

Fixed Issues (if relevant)

  1. magento/magento2#limiter float too generic magento/magento2#15323: Issue title limiter float too generic

Manual testing scenarios

  1. inspect toolbar in product list
  2. compare styles of .limiter and .pages

Actual Result

.limiter is too generic and is used as single selector for floating the element

Expected Result

.limiter should have the same parent selectors like .pages to prevent clashes between styles and layouts

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@hitesh-wagento hitesh-wagento merged commit 58600f5 into 2.3-develop Jun 6, 2018
hitesh-wagento pushed a commit that referenced this pull request Jul 14, 2018
[Forwardport] Fixed type hints and docs for Downloadable Samples block
hitesh-wagento pushed a commit that referenced this pull request Aug 29, 2018
@hitesh-wagento hitesh-wagento deleted the 2.3-develop-PR-port-15878 branch September 6, 2018 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants