Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add burnchain_op info to event emitter #216

Merged
merged 3 commits into from
Feb 21, 2023
Merged

Add burnchain_op info to event emitter #216

merged 3 commits into from
Feb 21, 2023

Conversation

kantai
Copy link
Contributor

@kantai kantai commented Feb 17, 2023

Description

This adds more detailed event information for burnchain ops (in this case, L1 operations), using the burnchain_op field which was added to stacks-blockchain in stacks-network/stacks-core#3517.

I still need to update the event-dispatcher.md documentation with these changes.

Applicable issues

Checklist

  • Test coverage for new or modified code paths
  • Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)

@kantai kantai linked an issue Feb 17, 2023 that may be closed by this pull request
@obycode
Copy link
Member

obycode commented Feb 21, 2023

Can #168 be closed in favor of this PR?

@saralab saralab requested a review from obycode February 21, 2023 17:05
@kantai
Copy link
Contributor Author

kantai commented Feb 21, 2023

Okay, updated the latest from master and added docs -- this should be ready for review.

Also, yes, I'm closing #168 in favor of this PR (this PR is closer to what got implemented in the stacks-node as well).

Copy link
Member

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kantai kantai merged commit 422d2d9 into master Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add base layer transaction type for API
2 participants