Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add burnchain op type to the new_block event #168

Closed
wants to merge 5 commits into from

Conversation

pavitthrap
Copy link
Contributor

@pavitthrap pavitthrap commented Oct 13, 2022

Description

This PR adds greater information about burnchain operations (such as DepositNft, DepositStx, etc), to the new_block event emitted by the event observer.

A new field is added for each tx json object, called burnchain_op, which contains information specific to the burn transaction.

Applicable issues

@codecov-commenter
Copy link

Codecov Report

Merging #168 (0996e27) into master (5e34058) will increase coverage by 11.14%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master     #168       +/-   ##
===========================================
+ Coverage   79.32%   90.47%   +11.14%     
===========================================
  Files         266        6      -260     
  Lines      173476      294   -173182     
===========================================
- Hits       137616      266   -137350     
+ Misses      35860       28    -35832     
Impacted Files Coverage Δ
src/chainstate/burn/operations/mod.rs
src/chainstate/stacks/db/blocks.rs
src/chainstate/stacks/events.rs
testnet/stacks-node/src/event_dispatcher.rs
testnet/stacks-node/src/tests/l1_observer_test.rs
src/chainstate/stacks/boot/docs.rs
src/cost_estimates/tests/fee_medians.rs
stacks-common/src/util/uint.rs
src/cost_estimates/fee_medians.rs
src/chainstate/stacks/index/marf.rs
... and 250 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link

@rafaelcr rafaelcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great @pavitthrap !
Is there a Docker build I could use through clarinet integrate so I can go over the NFT use case with these new payloads? Or what do you suggest?

Copy link
Contributor

@gregorycoppola gregorycoppola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool test!.. can we just wait to submit the commented stuff later?

@pavitthrap
Copy link
Contributor Author

It looks great @pavitthrap ! Is there a Docker build I could use through clarinet integrate so I can go over the NFT use case with these new payloads? Or what do you suggest?

Hi! I haven't actually run any subnets Docker images, but the command docker build -f ./Dockerfile.stretch -t stacks-subnets:demo-stretch . seems to work - let me know if that works!

@kantai
Copy link
Contributor

kantai commented Feb 21, 2023

Closing in favor of #216

@kantai kantai closed this Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add base layer transaction type for API
5 participants