Support processing parameters sent as a URL-encoded form #8325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The approach taken is intended to be conservative since we've always assumed JSON and not required Content-Type. Tools and libraries that default to "application/x-www-form-urlencoded" even when JSON is being sent (e.g. curl) will break without these extra backwards compatibility measures. This PR is a reboot of: #5935
ncabatoff
reviewed
Feb 12, 2020
ncabatoff
approved these changes
Feb 12, 2020
kalafut
pushed a commit
to hashicorp/vault-plugin-auth-jwt
that referenced
this pull request
Feb 13, 2020
form_post is not a commonly used mode but is needed for certain applications. Adding support for it impacted both the CLI and UI handler, as well as Vault (hashicorp/vault#8325). In addition to allowing configuration of `response_mode=form_post`, the operator can now also choose to configure `response_types`, which today is always `code`. This PR allows adding the `id_token` type as well. This is only supported if form_post is enabled. A curious aspect of this PR is to respond with some Javascript that writes to localStorage. This is a effectively doing what the UI does after a redirect, and allows the form_post support without modifying the UI code at all. There are cleaner options, but they would require a significant update to the UI.
kalafut
pushed a commit
to hashicorp/vault-plugin-auth-jwt
that referenced
this pull request
Feb 15, 2020
* Support form_post mode form_post is not a commonly used mode but is needed for certain applications. Adding support for it impacted both the CLI and UI handler, as well as Vault (hashicorp/vault#8325). In addition to allowing configuration of `response_mode=form_post`, the operator can now also choose to configure `response_types`, which today is always `code`. This PR allows adding the `id_token` type as well. This is only supported if form_post is enabled. A curious aspect of this PR is to respond with some Javascript that writes to localStorage. This is a effectively doing what the UI does after a redirect, and allows the form_post support without modifying the UI code at all. There are cleaner options, but they would require a significant update to the UI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The approach taken is intended to be conservative since we've always
assumed JSON and not required Content-Type. Tools and libraries that
default to "application/x-www-form-urlencoded" even when JSON is being
sent (e.g. curl) will break without these extra backwards compatibility
measures.
This PR is a reboot of: #5935