Correctly handle zero length values

hashicorp · Feb 12, 2020 · 8540377 · 8540377
1 parent 40e9485
commit 8540377
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/http/handler.go b/http/handler.go
@@ -623,7 +623,8 @@ func parseFormRequest(r *http.Request) (map[string]interface{}, error) {
 		data = make(map[string]interface{}, len(r.PostForm))
 		for k, v := range r.PostForm {
 			switch len(v) {
-			case 0, 1:
+			case 0:
+			case 1:
 				data[k] = v[0]
 			default:
 				// Almost anywhere taking in a string list can take in comma

diff --git a/http/handler_test.go b/http/handler_test.go
@@ -703,6 +703,7 @@ func TestHandler_Parse_Form(t *testing.T) {
 		"zip":   []string{"zap"},
 		"abc":   []string{"xyz"},
 		"multi": []string{"first", "second"},
+		"empty": []string{},
 	}
 	req, err := http.NewRequest("POST", cores[0].Client.Address()+"/v1/secret/foo", nil)
 	if err != nil {