Fixes issue when we need to attach/detach data disks #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sioned. By this we can attach disks on the go
…property is set This currently fails against the `master` branch: ``` $ acctests azurerm TestAccAzureRMPublicIpStatic_basic === RUN TestAccAzureRMPublicIpStatic_basic --- FAIL: TestAccAzureRMPublicIpStatic_basic (70.86s) testing.go:459: Step 0 error: Check failed: Check 2/3 error: azurerm_public_ip.test: Attribute 'ip_address' expected to be set FAIL exit status 1 FAIL github.com/terraform-providers/terraform-provider-azurerm/azurerm 70.886s ``` But will pass once #772 is merged: ``` $ acctests azurerm TestAccAzureRMPublicIpStatic_basic === RUN TestAccAzureRMPublicIpStatic_basic --- PASS: TestAccAzureRMPublicIpStatic_basic (83.19s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 83.219s ```
Set ip address on public_ip regardless of dns settings.
This provides a way to work around #582 by using the Azure Portal to attach disks.
`azurerm_public_ip`: Adding an acceptance test to check that the `ip_address` property is set
Fixes #785 Tests pass: ``` $ acctests azurerm TestAccDataSourceAzureRMStorageAccount_ === RUN TestAccDataSourceAzureRMStorageAccount_basic --- PASS: TestAccDataSourceAzureRMStorageAccount_basic (86.65s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 86.675s ```
- Updated the highlight on the Virtual Network Data Source - Added website documentation
…way-data-source New Data Source: `azurerm_virtual_network_gateway`
- Update the azure-sdk-for-go to v12.4.0-beta since this is the version that introduced 2017-12-01/compute - Change all 2017-03-30/compute import statements to 2017-12-01/compute
…account New Data Source: `azurerm_storage_account`
``` $ acctests azurerm TestAccDataSourceAzureRMBuiltInRoleDefinition_reader === RUN TestAccDataSourceAzureRMBuiltInRoleDefinition_reader --- PASS: TestAccDataSourceAzureRMBuiltInRoleDefinition_reader (12.15s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 12.185s ```
Fixing the Role Definition Data Source test
Set ignore case function for diffs on the managed data disk ids.
`azurerm_subnet` - add support for Service Endpoints
Update the compute API to 2017-12-01 / upgrading to Azure SDK v12.4
…-source-crash Data Source: `azurerm_virtual_network` - Fixing a crash when the DhcpOptions aren't specified
``` $ acctests azurerm TestAccAzureRMContainerGroup_ === RUN TestAccAzureRMContainerGroup_linuxBasic --- PASS: TestAccAzureRMContainerGroup_linuxBasic (65.69s) === RUN TestAccAzureRMContainerGroup_linuxBasicUpdate --- PASS: TestAccAzureRMContainerGroup_linuxBasicUpdate (67.84s) === RUN TestAccAzureRMContainerGroup_linuxComplete --- PASS: TestAccAzureRMContainerGroup_linuxComplete (70.88s) === RUN TestAccAzureRMContainerGroup_windowsBasic --- PASS: TestAccAzureRMContainerGroup_windowsBasic (70.94s) === RUN TestAccAzureRMContainerGroup_windowsComplete --- PASS: TestAccAzureRMContainerGroup_windowsComplete (59.38s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 334.768s ```
…up-tests Container Group: updating to use a Windows image
Grammar fixes to index.html.markdown
Added an option to have 0 in disk_size_gb property of managed_disk
|
the VM tests pass:
|
|
@VaijanathB would you be able to rebase this PR? |
…sioned. By this we can attach disks on the go
…orm-providers/terraform-provider-azurerm into FixDataDiskAttachRecreate
|
This is being merged as part of "Fix reprovisioning of VM when we attach and detach data disk. #813" |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we wanted to attach and detach a dataDisk after the VM creation, this was causing reprovisioning of the VM. By removing these two flags, now we can create new data disks and attach them to the existing vm.
Test cases run
This is a blocking issue for Sapient who are relying on Terraform for their third party tool.
The fix should fix this issue. #85