Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container Group: updating to use a Windows image #805

Merged
merged 1 commit into from
Feb 7, 2018

Conversation

tombuildsstuff
Copy link
Contributor

The tests are currently failing for this since the Windows Docker container was pulled:

------- Stdout: -------
=== RUN   TestAccAzureRMContainerGroup_windowsBasic
--- FAIL: TestAccAzureRMContainerGroup_windowsBasic (58.02s)
    testing.go:459: Step 0 error: Error applying: 1 error(s) occurred:
        
        * azurerm_container_group.test: 1 error(s) occurred:
        
        * azurerm_container_group.test: containerinstance.ContainerGroupsClient#CreateOrUpdate: Failure responding to request: StatusCode=400 -- Original Error: autorest/azure: Service returned an error. Status=400 Code="InaccessibleImage" Message="The image 'winappimage:latest' in container group 'acctestcontainergroup-4456597369366035246' is not accessible. Please check the image and registry credential."
FAIL

with these changes the tests now pass:

$ acctests azurerm TestAccAzureRMContainerGroup_
=== RUN   TestAccAzureRMContainerGroup_linuxBasic
--- PASS: TestAccAzureRMContainerGroup_linuxBasic (65.69s)
=== RUN   TestAccAzureRMContainerGroup_linuxBasicUpdate
--- PASS: TestAccAzureRMContainerGroup_linuxBasicUpdate (67.84s)
=== RUN   TestAccAzureRMContainerGroup_linuxComplete
--- PASS: TestAccAzureRMContainerGroup_linuxComplete (70.88s)
=== RUN   TestAccAzureRMContainerGroup_windowsBasic
--- PASS: TestAccAzureRMContainerGroup_windowsBasic (70.94s)
=== RUN   TestAccAzureRMContainerGroup_windowsComplete
--- PASS: TestAccAzureRMContainerGroup_windowsComplete (59.38s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	334.768s

```
$ acctests azurerm TestAccAzureRMContainerGroup_
=== RUN   TestAccAzureRMContainerGroup_linuxBasic
--- PASS: TestAccAzureRMContainerGroup_linuxBasic (65.69s)
=== RUN   TestAccAzureRMContainerGroup_linuxBasicUpdate
--- PASS: TestAccAzureRMContainerGroup_linuxBasicUpdate (67.84s)
=== RUN   TestAccAzureRMContainerGroup_linuxComplete
--- PASS: TestAccAzureRMContainerGroup_linuxComplete (70.88s)
=== RUN   TestAccAzureRMContainerGroup_windowsBasic
--- PASS: TestAccAzureRMContainerGroup_windowsBasic (70.94s)
=== RUN   TestAccAzureRMContainerGroup_windowsComplete
--- PASS: TestAccAzureRMContainerGroup_windowsComplete (59.38s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	334.768s
```
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tombuildsstuff tombuildsstuff merged commit 491c337 into master Feb 7, 2018
@tombuildsstuff tombuildsstuff deleted the fixing-container-group-tests branch February 7, 2018 15:08
@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants